Spec URL: https://bochecha.fedorapeople.org/packages/buildstream.spec SRPM URL: https://bochecha.fedorapeople.org/packages/buildstream-1.2.2-1.fc28.src.rpm Description: BuildStream is a Free Software tool for building/integrating software stacks. It takes inspiration, lessons and use-cases from various projects including OBS, Reproducible Builds, Yocto, Baserock, Buildroot, Aboriginal, GNOME Continuous, JHBuild, Flatpak Builder and Android repo. BuildStream supports multiple build-systems (e.g. autotools, cmake, cpan, distutils, make, meson, qmake), and can create outputs in a range of formats (e.g. debian packages, flatpak runtimes, sysroots, system images) for multiple platforms and chipsets. Fedora Account System Username: bochecha
Taking this review.
New upstream release: Spec URL: https://bochecha.fedorapeople.org/packages/buildstream.spec SRPM URL: https://bochecha.fedorapeople.org/packages/buildstream-1.2.3-1.fc28.src.rpm Also, note that I have Buildstream (and its missing dependencies, see the other reviews this depends on) in a temporary Copr: https://copr.fedorainfracloud.org/coprs/bochecha/buildstream/builds/
Here's a new package, with a fix so it builds on Rawhide. The patch is from the upstream master branch. Spec URL: https://bochecha.fedorapeople.org/packages/buildstream.spec SRPM URL: https://bochecha.fedorapeople.org/packages/buildstream-1.2.3-2.fc28.src.rpm --- diff --git a/buildstream.spec b/buildstream.spec index e2a13d1..b36a51a 100644 --- a/buildstream.spec +++ b/buildstream.spec @@ -4,9 +4,12 @@ License: LGPLv2+ URL: https://buildstream.gitlab.io/buildstream/ Version: 1.2.3 -Release: 1%{?dist} +Release: 2%{?dist} Source0: https://gitlab.com/BuildStream/buildstream/-/archive/%{version}/buildstream-%{version}.tar.bz2 +# https://gitlab.com/BuildStream/buildstream/merge_requests/874 +Patch0: 0001-bst2html.py-Name-the-second-argument-to-avoid-an-err.patch + BuildRequires: bubblewrap BuildRequires: python3-devel BuildRequires: python3-pytest-runner @@ -115,6 +118,9 @@ cp -pr doc/build/devhelp %{buildroot}%{_datadir}/gtk-doc/html/BuildStream %changelog +* Mon Dec 17 2018 Mathieu Bridon <bochecha> - 1.2.3-2 +- Make buildstream work with click 7. + * Fri Oct 05 2018 Mathieu Bridon <bochecha> - 1.2.3-1 - Update to the latest upstream release.
> %{py3_build} Please use "%py3_build" as it's a command macro. > %{py3_install} Same here.
The tarball seems to have a problem, according to fedora-review...? diff -U2 -r /home/makerpm/1634449-buildstream/upstream-unpacked/Source0/buildstream-1.2.3/buildstream/_version.py /home/makerpm/1634449-buildstream/srpm-unpacked/buildstream-1.2.3.tar.bz2-extract/buildstream-1.2.3/buildstream/_version.py --- /home/makerpm/1634449-buildstream/upstream-unpacked/Source0/buildstream-1.2.3/buildstream/_version.py 2018-10-05 03:01:57.000000000 -0400 +++ /home/makerpm/1634449-buildstream/srpm-unpacked/buildstream-1.2.3.tar.bz2-extract/buildstream-1.2.3/buildstream/_version.py 2018-10-05 03:01:57.000000000 -0400 @@ -25,5 +25,5 @@ # each be defined on a line of their own. _version.py will just call # get_keywords(). - git_refnames = " (tag: 1.2.3, refs/keep-around/10abe77fe8d77385d86f225b503d9185f4ef7f3a)" + git_refnames = " (tag: 1.2.3, refs/keep-around/10abe77fe8d77385d86f225b503d9185f4ef7f3a, bst-1.2)" git_full = "10abe77fe8d77385d86f225b503d9185f4ef7f3a" git_date = "2018-10-05 16:01:57 +0900"
Thanks for thez feedback Neal. Spec URL: https://bochecha.fedorapeople.org/packages/buildstream.spec SRPM URL: https://bochecha.fedorapeople.org/packages/buildstream-1.2.3-3.fc28.src.rpm --- diff --git a/buildstream.spec b/buildstream.spec index b36a51a..83f945f 100644 --- a/buildstream.spec +++ b/buildstream.spec @@ -4,7 +4,7 @@ License: LGPLv2+ URL: https://buildstream.gitlab.io/buildstream/ Version: 1.2.3 -Release: 2%{?dist} +Release: 3%{?dist} Source0: https://gitlab.com/BuildStream/buildstream/-/archive/%{version}/buildstream-%{version}.tar.bz2 # https://gitlab.com/BuildStream/buildstream/merge_requests/874 @@ -84,7 +84,7 @@ This package provides the documentation for BuildStream. %build -%{py3_build} +%py3_build pushd doc make devhelp @@ -92,7 +92,7 @@ popd %install -%{py3_install} +%py3_install mkdir -p %{buildroot}%{_datadir}/gtk-doc/html/ cp -pr doc/build/devhelp %{buildroot}%{_datadir}/gtk-doc/html/BuildStream @@ -118,6 +118,12 @@ cp -pr doc/build/devhelp %{buildroot}%{_datadir}/gtk-doc/html/BuildStream %changelog +* Mon Dec 17 2018 Mathieu Bridon <bochecha> - 1.2.3-3 +- Rebuild with the new release tarball + https://gitlab.com/BuildStream/buildstream/issues/820 +- Remove brackets around command macros, to avoid future annoyance if I add + arguments to them. + * Mon Dec 17 2018 Mathieu Bridon <bochecha> - 1.2.3-2 - Make buildstream work with click 7.
Package review notes: + Package follows package naming guidelines + Package follows Fedora general packaging guidelines + Package follows Fedora Python packaging guidelines + Package builds and installs cleanly + Packaging has no major issues from fedora-review PACKAGE APPROVED.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/buildstream
Thanks for the review and the SCM handling. Package is now built for F28+ and updates submitted, closing.