Created attachment 1488904 [details] Screenshot is showing actual results 5.9.5 Description of problem: Version-Release number of selected component (if applicable):5.9.5.0.20180927190514_e161d8f How reproducible:100% Steps to Reproduce: 1. Start Embedded Ansible server role 2. 3. Actual results: In notification message shows "The role Embedded Ansible has started Activation on server null" Expected results: It should show proper message like "The role Embedded Ansible has started activation on server EVM" Additional info:
https://github.com/ManageIQ/manageiq-ui-classic/pull/4730
New commit detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/96809410e76cb4fe4b37efaf8edba412a20593bf commit 96809410e76cb4fe4b37efaf8edba412a20593bf Author: Harpreet Kataria <hkataria> AuthorDate: Wed Oct 3 15:18:24 2018 -0400 Commit: Harpreet Kataria <hkataria> CommitDate: Wed Oct 3 15:18:24 2018 -0400 Made changes to save server name only if it is not blank Also fixed the check that compares previously saved value against the value from miq_server record instead of checking `@update.config[:server][:name]` server/name key did not exist in settings.yml so the condition always returned true. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1634518 app/controllers/ops_controller/settings/common.rb | 30 +- spec/controllers/ops_controller/settings/common_spec.rb | 33 + 2 files changed, 51 insertions(+), 12 deletions(-)
New commit detected on ManageIQ/manageiq-ui-classic/hammer: https://github.com/ManageIQ/manageiq-ui-classic/commit/f51dafbbb99b77c5812d1dbc405efdb67e1f33c5 commit f51dafbbb99b77c5812d1dbc405efdb67e1f33c5 Author: Dan Clarizio <dclarizi> AuthorDate: Wed Oct 3 18:39:22 2018 -0400 Commit: Dan Clarizio <dclarizi> CommitDate: Wed Oct 3 18:39:22 2018 -0400 Merge pull request #4730 from h-kataria/dont_allow_blank_appliance_name_for_server Made changes to save server name only if it is not blank (cherry picked from commit 50782950894f776f5d37e3fe1aa5c174737451c0) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1634518 app/controllers/ops_controller/settings/common.rb | 30 +- spec/controllers/ops_controller/settings/common_spec.rb | 33 + 2 files changed, 51 insertions(+), 12 deletions(-)
*** Bug 1638682 has been marked as a duplicate of this bug. ***
*** Bug 1639275 has been marked as a duplicate of this bug. ***
Hit this with 5.10.0.20 while testing LDAP auth. [root@dhcp-8-196-122 ~]# vmdb [root@dhcp-8-196-122 vmdb]# rake evm:status ** CFME 5.10.0.20, codename: Hammer Checking EVM status... Region | Zone | Server | --------+---------+----------+ 0 | default | UNKNOWN* | Server now shows UNKNOWN.
New commit detected on ManageIQ/manageiq-ui-classic/gaprindashvili: https://github.com/ManageIQ/manageiq-ui-classic/commit/cfb9de4fcd3d6f6d71175c03330419a918fc59b5 commit cfb9de4fcd3d6f6d71175c03330419a918fc59b5 Author: Harpreet Kataria <hkataria> AuthorDate: Mon Nov 5 16:37:27 2018 -0500 Commit: Harpreet Kataria <hkataria> CommitDate: Mon Nov 5 16:37:27 2018 -0500 Made changes to save server name only if it is not blank Also fixed the check that compares previously saved value against the value from miq_server record instead of checking `@update.config[:server][:name]` server/name key did not exist in settings.yml so the condition always returned true. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1634518 (cherry picked from commit 96809410e76cb4fe4b37efaf8edba412a20593bf) # Conflicts: # app/controllers/ops_controller/settings/common.rb # spec/controllers/ops_controller/settings/common_spec.rb app/controllers/ops_controller/settings/common.rb | 24 +- spec/controllers/ops_controller/settings/common_spec.rb | 31 + 2 files changed, 44 insertions(+), 11 deletions(-)
Able to see the proper Notification after Embedded Ansible server role enabled. Also it is not allowing empty server name. Verified Version: 5.10.0.23.20181106165157_92dd189