Bug 1638009 - [Regression] Ansible Role not enabled
Summary: [Regression] Ansible Role not enabled
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: Appliance
Version: 5.10.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: GA
: 5.10.0
Assignee: Nick Carboni
QA Contact: Satyajit Bulage
Red Hat CloudForms Documentation
URL:
Whiteboard:
Depends On:
Blocks: 1634518
TreeView+ depends on / blocked
 
Reported: 2018-10-10 13:32 UTC by Nikhil Dhandre
Modified: 2019-02-12 16:52 UTC (History)
10 users (show)

Fixed In Version: 5.10.0.20
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-02-12 16:52:49 UTC
Category: ---
Cloudforms Team: ---
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Comment 3 Nick Carboni 2018-10-12 13:46:01 UTC
This seems to be caused by a new check which makes sure that the rabbitmq password doesn't contain any special characters. This should be an easy fix, but I'm not sure how this will effect existing users on upgrade who's rabbitmq password already contains special characters.

Comment 5 CFME Bot 2018-10-12 16:23:17 UTC
New commit detected on ManageIQ/manageiq/hammer:

https://github.com/ManageIQ/manageiq/commit/a00ae17af2cd95f7f833763affcbff7880283fd8
commit a00ae17af2cd95f7f833763affcbff7880283fd8
Author:     Brandon Dunne <brandondunne>
AuthorDate: Fri Oct 12 11:12:12 2018 -0400
Commit:     Brandon Dunne <brandondunne>
CommitDate: Fri Oct 12 11:12:12 2018 -0400

    Merge pull request #18092 from carbonin/hex_ansible_passwords

    Don't use special characters in ansible passwords

    (cherry picked from commit 0a6e60e8f8c45a5718563ddb9d9e42a284c5d22c)

    https://bugzilla.redhat.com/show_bug.cgi?id=1638009

 lib/embedded_ansible.rb | 2 +-
 spec/lib/embedded_ansible_spec.rb | 9 +
 2 files changed, 10 insertions(+), 1 deletion(-)

Comment 6 CFME Bot 2018-10-12 16:23:23 UTC
New commit detected on ManageIQ/manageiq/master:

https://github.com/ManageIQ/manageiq/commit/27481df3761b55dd706ca440f3800cb765f60ebf
commit 27481df3761b55dd706ca440f3800cb765f60ebf
Author:     Nick Carboni <ncarboni>
AuthorDate: Fri Oct 12 10:45:19 2018 -0400
Commit:     Nick Carboni <ncarboni>
CommitDate: Fri Oct 12 10:45:19 2018 -0400

    Don't use special characters in ansible passwords

    The rabbitmq password has always needed to be URL-safe, but recently
    the tower team added a preflight-check in their setup playbook which
    just bans all special characters.

    This was causing setup failures even though our passwords were URL
    safe.

    Now, we just generate hex passwords.

    https://bugzilla.redhat.com/show_bug.cgi?id=1638009

 lib/embedded_ansible.rb | 2 +-
 spec/lib/embedded_ansible_spec.rb | 9 +
 2 files changed, 10 insertions(+), 1 deletion(-)

Comment 7 Nick Carboni 2018-10-12 17:08:27 UTC
https://github.com/ManageIQ/manageiq/pull/18092

Comment 9 CFME Bot 2018-10-12 19:42:16 UTC
New commit detected on ManageIQ/manageiq-schema/master:

https://github.com/ManageIQ/manageiq-schema/commit/ec81406fddc9cfc91c71d485113950b1fdcfb584
commit ec81406fddc9cfc91c71d485113950b1fdcfb584
Author:     Nick Carboni <ncarboni>
AuthorDate: Fri Oct 12 13:56:33 2018 -0400
Commit:     Nick Carboni <ncarboni>
CommitDate: Fri Oct 12 13:56:33 2018 -0400

    Generate a new ansible rabbitmq password

    If the current rabbitmq password contains special characters it
    will fail a new preflight check in the setup playbook.

    This is fixed for new installations by
    https://github.com/ManageIQ/manageiq/pull/18092 but because we
    re-run the setup playbook when we upgrade the tower version, we
    also need to correct existing ones.

    https://bugzilla.redhat.com/show_bug.cgi?id=1638009

 db/migrate/20181012160010_remove_special_characters_from_ansible_rabbitmq_password.rb | 25 +
 spec/migrations/20181012160010_remove_special_characters_from_ansible_rabbitmq_password_spec.rb | 55 +
 2 files changed, 80 insertions(+)

Comment 10 CFME Bot 2018-10-15 17:12:52 UTC
New commit detected on ManageIQ/manageiq-schema/hammer:

https://github.com/ManageIQ/manageiq-schema/commit/ff038c6575afec6cae8e1935fd725889c56b45ab
commit ff038c6575afec6cae8e1935fd725889c56b45ab
Author:     Brandon Dunne <brandondunne>
AuthorDate: Fri Oct 12 15:25:32 2018 -0400
Commit:     Brandon Dunne <brandondunne>
CommitDate: Fri Oct 12 15:25:32 2018 -0400

    Merge pull request #289 from carbonin/generate_new_ansible_rabbit_password

    Generate a new ansible rabbitmq password

    (cherry picked from commit af113564ede0f37b3d417e7b0f20760a9be29733)

    https://bugzilla.redhat.com/show_bug.cgi?id=1638009

 db/migrate/20181012160010_remove_special_characters_from_ansible_rabbitmq_password.rb | 25 +
 spec/migrations/20181012160010_remove_special_characters_from_ansible_rabbitmq_password_spec.rb | 55 +
 2 files changed, 80 insertions(+)

Comment 11 Satyajit Bulage 2018-10-17 10:37:29 UTC
Ansible Role enabled without any error.

Verified Version: 5.10.0.20.20181016163900_fe677b4


Note You need to log in before you can comment on or make changes to this bug.