Bug 1643733 - [upgrade] Post upgrade, new options are not available in virt profile
Summary: [upgrade] Post upgrade, new options are not available in virt profile
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-node
Classification: oVirt
Component: General
Version: 4.2
Hardware: x86_64
OS: Linux
unspecified
high
Target Milestone: ovirt-4.3.0
: ---
Assignee: Yuval Turgeman
QA Contact: Huijuan Zhao
URL:
Whiteboard:
Depends On:
Blocks: 1643730 1654147
TreeView+ depends on / blocked
 
Reported: 2018-10-28 03:04 UTC by SATHEESARAN
Modified: 2019-02-13 07:45 UTC (History)
7 users (show)

Fixed In Version: imgbased-1.1.2
Clone Of: 1643730
: 1654147 (view as bug list)
Environment:
Last Closed: 2019-02-13 07:45:10 UTC
oVirt Team: Node
Embargoed:
rule-engine: ovirt-4.3+
huzhao: testing_plan_complete+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 95207 0 master ABANDONED osupdater: copy over new files when migrating /var 2020-07-06 09:22:10 UTC
oVirt gerrit 95611 0 master MERGED Sync existing files in /var 2020-07-06 09:22:10 UTC
oVirt gerrit 95779 0 ovirt-4.2 MERGED Sync existing files in /var 2020-07-06 09:22:10 UTC

Description SATHEESARAN 2018-10-28 03:04:42 UTC
Description of problem:
-----------------------
After upgrading from RHV 4.1.11, the new virt options are not available in virt profile ( /var/lib/glusterd/groups/virt )

Version-Release number of selected component (if applicable):
--------------------------------------------------------------
RHVH 4.1.11
RHVH 4.2.7

How reproducible:
------------------
6/6

Steps to Reproduce:
-------------------
1. Install RHVH 4.1.11
2. Check for the contents of virt profile 
3. Update to the latest RHVH 4.2.7
4. Check for the contents of virt profile

Actual results:
---------------
New virt profile still points to the old content


Expected results:
------------------
New virt profile should have the new content
Additional info:

Comment 1 Huijuan Zhao 2018-10-29 05:49:33 UTC
QE can reproduce this issue.

Test version:
# imgbase layout
rhvh-4.1-0.20180425.0
 +- rhvh-4.1-0.20180425.0+1
rhvh-4.2.7.3-0.20181026.0
 +- rhvh-4.2.7.3-0.20181026.0+1

Test steps:
1. Install redhat-virtualization-host-4.1-20180426.0
2. Check for the contents of virt profile /var/lib/glusterd/groups/virt
3. Upgrade rhvh to 4.2.7 rhvh-4.2.7.3-0.20181026.0
4. Check for the contents of virt profile /var/lib/glusterd/groups/virt
5. Clean install rhvh-4.2.7.3-0.20181026.0
6. Check for the contents of virt profile /var/lib/glusterd/groups/virt


Test results:
1. After step 4, the contents of virt profile is same as step 2:
# cat /var/lib/glusterd/groups/virt
performance.quick-read=off
performance.read-ahead=off
performance.io-cache=off
performance.low-prio-threads=32
network.remote-dio=enable
cluster.eager-lock=enable
cluster.quorum-type=auto
cluster.server-quorum-type=server
cluster.data-self-heal-algorithm=full
cluster.locking-scheme=granular
cluster.shd-max-threads=8
cluster.shd-wait-qlength=10000
features.shard=on
user.cifs=off

2. After step 6, the contents of virt profile is not same as step 4:
# cat /var/lib/glusterd/groups/virt
performance.quick-read=off
performance.read-ahead=off
performance.io-cache=off
performance.low-prio-threads=32
network.remote-dio=enable
cluster.eager-lock=enable
cluster.quorum-type=auto
cluster.server-quorum-type=server
cluster.data-self-heal-algorithm=full
cluster.locking-scheme=granular
cluster.shd-max-threads=8
cluster.shd-wait-qlength=10000
features.shard=on
user.cifs=off
cluster.choose-local=off
client.event-threads=4
server.event-threads=4
performance.client-io-threads=on

Comment 3 Huijuan Zhao 2018-11-29 06:11:05 UTC
This bug is fixed in redhat-virtualization-host-4.2-20181128.0

Test version:
# imgbase layout
rhvh-4.1-0.20180425.0
 +- rhvh-4.1-0.20180425.0+1
rhvh-4.2.8.0-0.20181127.0
 +- rhvh-4.2.8.0-0.20181127.0+1

Test steps:
Same as comment 1

Test results:
1. After step4, the contents of virt profile is different as step 2
2. After step6, the contents of virt profile is same as step 4
So new virt profile has the new content.


I checked the process to handle /var during upgrade via /var/log/imgbased.log, and tested some special configurations in /var which should be persisted from old layer, all are ok.
Such as: modified files in /var/imgbased/persisted-rpms/, /var/log, /var/crash, /var


So this bug is fixed in rhvh-4.2.8.0-0.20181127.0, will verify this bug once the status move to ON_QA.

Comment 6 Huijuan Zhao 2019-01-15 06:02:06 UTC
Tested in redhat-virtualization-host-4.3-20190109.0 according to Comment 3, this bug is fixed.

Move the status to VERIFIED.

Comment 7 Sandro Bonazzola 2019-02-13 07:45:10 UTC
This bugzilla is included in oVirt 4.3.0 release, published on February 4th 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.3.0 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.