Spec URL: https://ankursinha.fedorapeople.org/python-efel/python-efel.spec SRPM URL: https://ankursinha.fedorapeople.org/python-efel/python-efel-3.0.22-1.fc29.src.rpm Description: The Electrophys Feature Extraction Library (eFEL) allows neuroscientists to automatically extract features from time series data recorded from neurons (both in vitro and in silico). Examples are the action potential width and amplitude in voltage traces recorded during whole-cell patch clamp experiments. The user of the library provides a set of traces and selects the features to be calculated. The library will then extract the requested features and return the values to the user. The core of the library is written in C++, and a Python wrapper is included. At the moment we provide a way to automatically compile and install the library as a Python module. Fedora Account System Username: ankursinha
F29 scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=31005180 Rawhide scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=31005076
hello Ankur the spec look good, just a small change - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: gcc-c++ See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 the "BuildRequires: gcc-c++" can be remove.
(In reply to Luis Segundo from comment #2) > hello Ankur the spec look good, just a small change Thanks for the review, Luis! > - All build dependencies are listed in BuildRequires, except for any that > are listed in the exceptions section of Packaging Guidelines. > Note: These BR are not needed: gcc-c++ > See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 > > the "BuildRequires: gcc-c++" can be remove. I think this is a false positive. The guidelines are now on docs.fp.o, and this link fedora-review gives does not point to anything related to such an issue either. So maybe fedora review is not up to date? I'm not sure what it's pointing to here: g++ is necessary for this package, otherwise the build fails. Here is a scratch build that shows this: https://koji.fedoraproject.org/koji/taskinfo?taskID=31014016 Even using "gcc" instead of "gcc-c++" fails since the build process cannot find the g++ compiler: https://koji.fedoraproject.org/koji/taskinfo?taskID=31014100 Cheers, Ankur
(In reply to Ankur Sinha (FranciscoD) from comment #3) > (In reply to Luis Segundo from comment #2) > I think this is a false positive. Hello Ankur, if it makes sense Package approved! Cheers,
Thanks for the review Luis. SCM requested: https://pagure.io/releng/fedora-scm-requests/issue/8927
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-efel
python-efel-3.0.22-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-91dbe4e2b6
python-efel-3.0.22-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-1531eeb1bd
python-efel-3.0.22-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-91dbe4e2b6
python-efel-3.0.22-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-1531eeb1bd
python-efel-3.0.22-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.
python-efel-3.0.22-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.