Red Hat Bugzilla – Bug 165313
Fix debuginfo package, add in $PATH
Last modified: 2007-11-30 17:11:11 EST
find-debuginfo.sh doesn't strip setuid/setgid binaries (dunno if that's on
purpose), and powermanga is affected -> it creates a useless -debuginfo
package. Additionally the game is not in the
default $PATH. Fix for both attached.
Created attachment 117528 [details]
Make launchable from $PATH, fix -debuginfo
Hmph, uploaded wrong version of the patch; my intention was to use /bin/bash
(not /bin/sh) for the launcher script in /usr/bin because I don't know if "$@"
works in all shells. I'm too lazy to upload another one ;)
1) I really don't see how your patch can change anything about the debuginfo
problem, and I had already noticed it, posted to some list (can't remember
which), but didn't get any useful feedback.
2) I don't get the point of having the binary in $PATH when it's a graphical
application, a system menu entry is provided, and it's the default for the
original sources. I've already discussed this for another package (viruskiller
Like said in the initial comment, find-debuginfo.sh does not strip
setuid/setgid binaries. Believe me, this patch does fix it :)
I see the point of being able to launch every single user visible application
that is meant to be launched by typing its name. I use the menus actually
_very_ rarely, and I don't believe I'm the only one.
Oh, and I bet the upstream default of installing the binary
to /usr/games/powermanga is because /usr/games is in $PATH in many Unix/Linux
systems by default. Not so in Red Hat's products...
See bug 117858 for the setgid/setuid not stripped stuff.
I'm a bit tired, so maybe I'm just missing something... but I really don't see
anything in the attached patch relevant to the debuginfo problem :-/
Created attachment 117533 [details]
Really fix debuginfo, and put an executable in $PATH
Crap, my bad, I'm even more tired. It was a wrong version of the patch indeed,
here's the corrected one.
OK, I surrender... I'll put the wrapper script in $PATH... but still, I don't
like it as for me, GUI apps that default to not being in $PATH are a non-issue
as long as they are provided with a working menu entry ;-p