+++ This bug was initially created as a clone of Bug #1652459 +++

Description of problem:
When configured to serve VLAN interfaces, the radvd unit fails to start at boot.


Version-Release number of selected component (if applicable):
radvd-2.17-10.fc28.x86_64

How reproducible:
Every time.

Steps to Reproduce:
1. Configure radvd to advertise on VLAN interfaces.
2. Reboot.
3. Watch radvd fail to start.

Actual results:
Failed unit startup.

Expected results:
Running radvd.service unit.

Additional info:

--- Additional comment from Ben Herrick on 2018-11-22 02:28:54 EST ---

From journalctl:

Nov 18 14:55:30 xxxx radvd[1191]: version 2.17 started
Nov 18 14:55:30 xxxx radvd[1191]: IPv6 forwarding setting is: 0, should be 1 or 2
Nov 18 14:55:30 xxxx radvd[1191]: IPv6 forwarding seems to be disabled, but continuing anyway
Nov 18 14:55:30 xxxx radvd[1194]: enp2s0.254 not found: No such device

--- Additional comment from Pavel Zhukov on 2018-11-22 06:05:46 EST ---

Hello,

Thank you for the bug report.
It's weird nobody was noticed before. The fix is simple one line patch. I'll submit it upstream

--- Additional comment from Pavel Zhukov on 2018-11-26 10:06:45 EST ---

it's weird I've checked version in rawhide and it works fine. 

#without vlan device:

Nov 26 16:02:45 pzhukov-x240.example.com systemd[1]: Starting Router advertisement daemon for IPv6...
Nov 26 16:02:45 pzhukov-x240.example.com radvd[10087]: version 2.17 started
Nov 26 16:02:45 pzhukov-x240.example.com radvd[10087]: IPv6 forwarding setting is: 0, should be 1 or 2
Nov 26 16:02:45 pzhukov-x240.example.com radvd[10087]: IPv6 forwarding seems to be disabled, but continuing anyway
Nov 26 16:02:45 pzhukov-x240.example.com systemd[1]: Started Router advertisement daemon for IPv6.
Nov 26 16:02:45 pzhukov-x240.example.com radvd[10088]: enp0s25.100 not found: No such device


# sudo ip link add link enp0s25 name enp0s25.100 type vlan id 100

# with vlan device
-- Logs begin at Mon 2018-11-19 10:50:53 CET, end at Mon 2018-11-26 15:57:22 CET. --
Nov 26 15:57:14 pzhukov-x240.example.com systemd[1]: Starting Router advertisement daemon for IPv6...
Nov 26 15:57:14 pzhukov-x240.example.com radvd[9677]: version 2.17 started
Nov 26 15:57:14 pzhukov-x240.example.com radvd[9677]: IPv6 forwarding setting is: 0, should be 1 or 2
Nov 26 15:57:14 pzhukov-x240.example.com radvd[9677]: IPv6 forwarding seems to be disabled, but continuing anyway
Nov 26 15:57:14 pzhukov-x240.example.com systemd[1]: Started Router advertisement daemon for IPv6.


# radvd.conf
interface enp0s25.100
{
// omitted

};

There were not too many changes between f28 and rawhide
Can you please double check your config? 


+* Wed Jun 13 2018 Pavel Zhukov <pzhukov> - 2.17-14
+- Log to stderr in non-daemon mode
+- Add nodaemon option into manpage
+- Re-enable test again
+
+* Mon Jun 04 2018 Pavel Zhukov <pzhukov> - 2.17-12
+- Enable tests and fix them on big endian arches
+
+* Thu Apr 12 2018 Pavel Zhukov <pzhukov> - 2.17-11
+- Enable Werror=all

--- Additional comment from Ben Herrick on 2018-11-26 22:16:18 EST ---

Try adding the VLAN interface using nmcli and then reboot.

The problem does not occur when starting radvd after the system is booted, but radvd will fail because the VLAN interfaces are started _AFTER_ radvd.

--- Additional comment from Ben Herrick on 2018-11-26 22:19:54 EST ---

To be clear, you have to add the VLAN interface permanently in nmcli, also add the configuration for the prefix/interface in /etc/radvd.conf and then reboot in order to observe the behavior.

--- Additional comment from Pavel Zhukov on 2018-11-27 02:52:42 EST ---

(In reply to Ben Herrick from comment #4)
> Try adding the VLAN interface using nmcli and then reboot.
> 
> The problem does not occur when starting radvd after the system is booted,
> but radvd will fail because the VLAN interfaces are started _AFTER_ radvd.

It's different problem and seems like radvd has nothing to do with it but NM brings vlan interface up too late.

[Unit]
Description=Router advertisement daemon for IPv6
After=network.target

--- Additional comment from Beniamino Galvani on 2018-11-27 03:27:20 EST ---

If radvd needs that all connection profiles are activated when it's started, it should depend on the network-online.target in this way:

 After=network-online.target
 Wants=network-online.target

so that it is delayed until NetworkManager has completed the initialization. The NetworkManager-wait-online.service should be active as well.

--- Additional comment from Pavel Zhukov on 2018-11-27 03:50:47 EST ---

(In reply to Beniamino Galvani from comment #7)
> If radvd needs that all connection profiles are activated when it's started,
> it should depend on the network-online.target in this way:
> 
>  After=network-online.target
>  Wants=network-online.target
> 
> so that it is delayed until NetworkManager has completed the initialization.
> The NetworkManager-wait-online.service should be active as well.

Ok. Thanks. Moving back then.
Sorry for the noise

--- Additional comment from Pavel Zhukov on 2018-11-27 03:51:08 EST ---

(In reply to Beniamino Galvani from comment #7)
> If radvd needs that all connection profiles are activated when it's started,
> it should depend on the network-online.target in this way:
> 
>  After=network-online.target
>  Wants=network-online.target
> 
> so that it is delayed until NetworkManager has completed the initialization.
> The NetworkManager-wait-online.service should be active as well.

Ok. Thanks. Moving back then.
Sorry for the noise

--- Additional comment from Fedora Update System on 2018-11-27 06:15:55 EST ---

radvd-2.17-11.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-3222e7c914

--- Additional comment from Fedora Update System on 2018-11-27 06:16:37 EST ---

radvd-2.17-16.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-b333ac9645