Spec Name or Url: ftp://packman.iu-bremen.de/fedora/SRPMS/perl-Number-Compare.spec SRPM Name or Url: ftp://packman.iu-bremen.de/fedora/SRPMS/perl-Number-Compare-0.01-2.src.rpm Description: Number::Compare compiles a simple comparison to an anonymous subroutine, which you can call with a value to be tested again.
Looks fine. Once again, sure about the license? Shouldn't it be just 'Artistic'?
The documentation in the package ("man Number::Compare" if you've installed it) states: "This module is free software; you can redistribute it and/or modify it under the same terms as Perl itself" So it's "Artistic or GPL", the same as perl itself.
Hmm? May I cite my spec file (line 5): ... License: Artistic or GPL ...
Re: Comment #3, I agree with you - it was Comment #1 I was addressing.
OK, then from my side, it's OK.
Just a minor note: The following line find $RPM_BUILD_ROOT -type f -name '*.bs' -a -size 0 -exec rm -f {} ';' is not needed for noarch packages. Everything else looks good.
Review: - rpmlint clean - package/spec follows naming guidelines - package follows packaging guidelines - license is OK - same as perl - spec file is in English and is perfectly legible - source matches upstream - build fine in mock for -devel (i386) - no explicit BRs - no locales, libraries, headers, pkgconfigs, subpackages to worry about - not relocatable - directory ownership OK - no duplicate files - file permissions OK - %clean present and correct - macro usage is consistent - code, not content - no large docs - manpage does not affect running of package - package appears to work Would suggest adding to %description: Now this would be very pointless, if Number::Compare didn't understand magnitudes. The target value may use magnitudes of kilobytes (k, ki), megabytes (m, mi), or gigabytes (g, gi). Those suffixed with an i use the appropriate 2**n version in accordance with the IEC standard: http://physics.nist.gov/cuu/Units/binary.html Please also note Comment #6 re empty .bs files. Approved.