Spec Name or Url: ftp://packman.iu-bremen.de/fedora/SRPMS/perl-File-Find-Rule.spec SRPM Name or Url: ftp://packman.iu-bremen.de/fedora/SRPMS/perl-File-Find-Rule-0.28-2.src.rpm Description: File::Find::Rule is a friendlier interface to File::Find. It allows you to build rules which specify the desired files and directories
Review: - rpmlint clean - naming of package and spec meets guidelines - package meets guidelines - license same as perl - spec file written in English and is legible - source matches upstream - package builds ok in FC4 and in mock for devel (i386) - no locales, libraries, subpackages, pkgconfigs etc. to worry about - not relocatable - no directory ownership issues - no duplicate files - permissions are fine - %clean section present and correct - macro usage is consistent - code, not content - no large docs - docs don't affect runtime Nitpick: - BR: perl not needed - Finding empty .bs files not needed for noarch package These can be addressed post-CVS. I'm happy with this, and will review the BR: perl(Text::Glob) shortly. Approved.