Spec Name or Url: ftp://packman.iu-bremen.de/fedora/SRPMS/perl-Text-Glob.spec SRPM Name or Url: ftp://packman.iu-bremen.de/fedora/SRPMS/perl-Text-Glob-0.06-2.src.rpm Description: Text::Glob implements glob(3) style matching that can be used to match against text, rather than fetching names from a filesystem. If you want to do full file globbing use the File::Glob module instead.
Review: - rpmlint clean - package and spec naming fine - package meets guidelines - license is same as perl - spec written in English and is legible - source matches upstream - package builds ok in FC4 and in mock for devel (i386) - no locales, libraries, subpackages, pkgconfigs etc. to worry about - not relocatable - no directory ownership issues - no duplicate files - permissions are fine - %clean section present and correct - macro usage is consistent - code, not content - no large docs - docs don't affect runtime Nitpick: - BR: perl not needed - Finding empty .bs files not needed for noarch package These can be addressed post-CVS. I'm happy with this. Approved.