Bug 165880 - scriptlet issues
Summary: scriptlet issues
Keywords:
Status: CLOSED DUPLICATE of bug 165803
Alias: None
Product: Red Hat Enterprise Linux 4
Classification: Red Hat
Component: tog-pegasus
Version: 4.0
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
: ---
Assignee: Jason Vas Dias
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2005-08-13 14:44 UTC by Joe Orton
Modified: 2007-11-30 22:07 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2005-08-18 02:34:59 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Joe Orton 2005-08-13 14:44:43 UTC
Split from bug 165803:

1. %post has lots of output to stdout.  All scriptlets should be silent.

[root@tango RPMS]# rpm -ivh tog-pegasus-2.4.1-1.i386.rpm
Preparing...                ########################################### [100%]
   1:tog-pegasus            ########################################### [100%]
 Generating SSL certificates...
 To start Pegasus manually:
 /etc/init.d/tog-pegasus start
 Stop it:
 /etc/init.d/tog-pegasus stop
 To set up PATH and MANPATH in /etc/profile
 run /opt/tog-pegasus/sbin/settogpath.
[root@tango RPMS]#

2. %post should not be logging:

mkdir -p /var/opt/tog-pegasus/log
echo `date` >/var/opt/tog-pegasus/log/install.log 2>&1

and the .../log the directory should be package-managed not created by %post.
And it should be in /var/log but hey.

3. %postun does "rm -rf /opt/tog-pegasus", and more -- totally unacceptable. 
This is a workaround for creating all the symlinks, perhaps?  /opt/tog-pegasus
is packaged.  It shouldn't need to be removed manually in %postun.  It should
not remove *all* configuration files from /etc/opt/tog-pegasus, either, again
very bad practice; remove just the config files which are automatically created
by %post perhaps.

4. there should be a "Requires(post): " line listing all the things the %post
script requires: openssl, lsb, etc.  likewise for other scriptlets.

5. the symlinks from .so.N to .so should not be created in %post - they should
be packaged in the -devel^W-sdk subpackage.

Comment 1 Jason Vas Dias 2005-08-18 02:34:59 UTC
All the above issues are now fixed with tog-pegasus-2.4.1-2.rhel4 - 
see bug 165803 .


*** This bug has been marked as a duplicate of 165803 ***


Note You need to log in before you can comment on or make changes to this bug.