Bug 165957 - Review Request: esmtp. Relay only MTA.
Summary: Review Request: esmtp. Relay only MTA.
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Aurelien Bompard
QA Contact: David Lawrence
URL: http://esmtp.sourceforge.net/
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2005-08-15 10:21 UTC by Patrice Dumas
Modified: 2007-11-30 22:11 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-07-23 12:39:22 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Patrice Dumas 2005-08-15 10:21:27 UTC
SRPM Name or Url: http://www.environnement.ens.fr/docs/fc-srpms/esmtp-0.5.1-3.src.rpm
Description: 

ESMTP is a user configurable relay-only Mail Transfer Agent (MTA) with a
sendmail-compatible syntax. It's based on libESMTP supporting the AUTH
(including the CRAM-MD5 and NTLM SASL mechanisms) and the StartTLS SMTP
extensions.

So these are ESMTP features:
 * requires no administration privileges
 * individual user configuration
 * sendmail command line compatible
 * supports the AUTH SMTP extension, with the CRAM-MD5 and NTLM SASL
   mechanisms
 * support the StartTLS SMTP extension
 * does not receive mail, expand aliases or manage a queue

Comment 1 Patrice Dumas 2005-08-15 10:34:12 UTC
I took the upstream spec tweaked it a little. I used the alternative  system
copying what is done for exim, so that it can be a sendmail replacement and
provide smtpdaemon. It might not be a good idea as fetchmail requires a
smtpdaemon that listen on the smtp port as a fallback in case the mda don't
accept mail,
so it is not a real replacement for smtpdaemon which corresponds with 2
(orthogonal) things, a send mail MTA and a SMTP receiving daemon.

See for example
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=66396#c4

Comment 2 Patrice Dumas 2005-08-15 10:35:56 UTC
I have a better srpm with a Source url that works:

http://www.environnement.ens.fr/docs/fc-srpms/esmtp-0.5.1-4.src.rpm

Comment 3 Aurelien Bompard 2005-08-25 16:16:04 UTC
* I would advise against providing smtpdaemon, since esmtp is not a daemon at
all, and programs like fetchmail could think their requirement is fulfilled
while it is not (nothing listening on port 25)

* Don't put the german translation in the filename. IIRC the policy it not to
include translations except if the package is strongly related to a particular
language (which is not the case here)

* Spec file encoding should be either ASCII UTF-8, but I think this will be
solved when the german parts are gone.

* PreReq should be Requires(post)

* Missing BuildRequires: openssl-devel

* To copy source 1 I would just do "cp %{SOURCE1} mutt-esmtp ." since the
working directory is the building dir, but that's minor.


Comment 4 Patrice Dumas 2005-08-26 13:11:22 UTC
I removed the provide smtpdaemon, now the drawback is that mutt require
smtpdaemon, so a smtp listener must be installed even though none is needed.   

I changed the german accents to utf-8, and then put the translations in comments
such that they are not lost.

The PreReq came from exim.spec... Thanks for the explanation.

openssl-devel is not BuildRequired, it is a dependency for libesmtp-devel. I
filled a bug against libesmtp.

I copy the mutt-esmtp now in the %setup using your command.

See the srpm here:
http://www.environnement.ens.fr/docs/fc-srpms/esmtp-0.5.1-5.src.rpm


Comment 5 Aurelien Bompard 2005-08-26 13:28:56 UTC
> I removed the provide smtpdaemon, now the drawback is that mutt require
> smtpdaemon, so a smtp listener must be installed even though none is needed.

Right... I don't know what the best solution would be, maybe you should ask
fedora-extras-list...

> openssl-devel is not BuildRequired, it is a dependency for libesmtp-devel. I
> filled a bug against libesmtp.

You're right, but the package won't build in the buildsystem as long as
openssl-devel is not buildrequired in a way or another. Could you add the BR
temporarily and remove it when libesmtp-devel is fixed ?

The spec file is still not utf-8 :
$ file esmtp.spec
esmtp.spec: ISO-8859 English text

you can use "recode ISO-8859-1..UTF-8 esmtp.spec" to convert it

Apart from that everything looks OK.

Comment 6 Patrice Dumas 2005-08-26 20:43:25 UTC
Regarding smtpdaemon I think it is not a terrible issue, lets keep it like this.

Hopefully the utf8 issue is solved and I added the BR in:

http://www.environnement.ens.fr/docs/fc-srpms/esmtp-0.5.1-6.src.rpm

Comment 7 Aurelien Bompard 2005-08-28 17:05:10 UTC
Looks good :
* RPM name is OK
* Spec change looks OK
* Source esmtp-0.5.1.tar.bz2 is the same as upstream
* The BuildRoot is the preferred one
* Builds fine in mock
* rpmlint agrees
* Seems to be working fine


Comment 8 Aurelien Bompard 2005-08-28 21:22:30 UTC
According to http://fedoraproject.org/wiki/PackageReviewGuidelines, I was
mistaken about the german translation. Please re-enable it before or after
importing into CVS. Thanks

Comment 9 Patrice Dumas 2005-08-31 21:14:55 UTC
I reenabled the german translations and built. 

Comment 10 Patrice Dumas 2006-07-21 20:25:04 UTC
Aurelien, you should assign that bug to yourself.

Comment 11 Aurelien Bompard 2006-07-23 12:39:22 UTC
Done, thanks


Note You need to log in before you can comment on or make changes to this bug.