Spec Name or Url: http://www.auroralinux.org/people/spot/review/Maypole/perl-Class-DBI-Pager.spec SRPM Name or Url: http://www.auroralinux.org/people/spot/review/Maypole/perl-Class-DBI-Pager-0.06-2.src.rpm Description: Pager utility for Class::DBI (NOTE: This package is one of the Maypole dependencies)
Review: - rpmlint clean - package and spec naming OK - package meets guidelines - license is same as perl, matches spec - spec file written in ENglish and is legible - sources match upstream - builds OK in mock on FC4 (i386) - no locales, libraries, subpackages or pkgconfigs to worry about - not relocatable - do directory ownership or permissions issues - no duplicate files - %clean section present and correct - macro usage is consistent - code, not content - no large docs - docs don't affect runtime - no scriptlets Needswork: - remove redundant BR: perl - add BR: perl(Data::Page), perl(Exporter::Lite), perl(DBD::SQLite) - include license text Nitpicks: - honor %%{_smp_mflags} - remove explicit perl(Class::DBI) dep - it's autodetected
Created attachment 118457 [details] Patch addressing review issues
fixed in -3: SRPM: http://www.auroralinux.org/people/spot/review/Maypole/perl-Class-DBI-Pager-0.06-3.src.rpm SPEC: http://www.auroralinux.org/people/spot/review/Maypole/perl-Class-DBI-Pager.spec
Approved.