Spec Name or Url: http://www.auroralinux.org/people/spot/review/Maypole/perl-Data-Page.spec SRPM Name or Url: http://www.auroralinux.org/people/spot/review/Maypole/perl-Data-Page-2.00-2.src.rpm Description: Help when paging through sets of results. (NOTE: This package is one of the Maypole dependencies)
Review: - rpmlint clean - package and spec naming OK - package meets guidelines - license is same as perl, spec matches - spec written in English and is legible - sources match upstream - package builds OK in mock for FC4 (i386) - no locales, libraries, subpackages, pkgconfigs etc. to worry about - not relocatable - no directory ownership or permissions errors - %clean section present and correct - macro usage consistent - code, not content - no large docs - docs don't affect runtime - no scriptlets Needswork: - explicit Requires: perl(Class::Accessor::Chained::Fast) needed, not picked up automatically Nitpick: - redundant BR: perl - license text not included; suggest the usual fix - suggest including CHANGES as %doc - make called without %{?_smp_mflags} - BR: perl(Class::Accessor::Chained) should really be perl(Class::Accessor::Chained::Fast), though the same package provides both - add BR: perl(Test::Pod) & perl(Test::Pod::Coverage) for improved test cover
Created attachment 118105 [details] Patch addressing review issues
All issues fixed in -3. New SRPM: http://www.auroralinux.org/people/spot/review/Maypole/perl-Data-Page-2.00-3.src.rpm New SPEC: http://www.auroralinux.org/people/spot/review/Maypole/perl-Data-Page.spec
Approved.