Bug 166199 - Review Request: perl-Data-Page : Help when paging through sets of results
Review Request: perl-Data-Page : Help when paging through sets of results
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Paul Howarth
David Lawrence
http://search.cpan.org/dist/Data-Page/
:
Depends On: 166183
Blocks: FE-ACCEPT 166190
  Show dependency treegraph
 
Reported: 2005-08-17 16:46 EDT by Tom "spot" Callaway
Modified: 2007-11-30 17:11 EST (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2005-08-30 21:50:14 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:


Attachments (Terms of Use)
Patch addressing review issues (1.77 KB, patch)
2005-08-25 07:01 EDT, Paul Howarth
no flags Details | Diff

  None (edit)
Description Tom "spot" Callaway 2005-08-17 16:46:36 EDT
Spec Name or Url: 
http://www.auroralinux.org/people/spot/review/Maypole/perl-Data-Page.spec

SRPM Name or Url:
http://www.auroralinux.org/people/spot/review/Maypole/perl-Data-Page-2.00-2.src.rpm

Description: 

Help when paging through sets of results.

(NOTE: This package is one of the Maypole dependencies)
Comment 1 Paul Howarth 2005-08-25 07:00:28 EDT
Review:

- rpmlint clean
- package and spec naming OK
- package meets guidelines
- license is same as perl, spec matches
- spec written in English and is legible
- sources match upstream
- package builds OK in mock for FC4 (i386)
- no locales, libraries, subpackages, pkgconfigs etc. to worry about
- not relocatable
- no directory ownership or permissions errors
- %clean section present and correct
- macro usage consistent
- code, not content
- no large docs
- docs don't affect runtime
- no scriptlets

Needswork:

- explicit Requires: perl(Class::Accessor::Chained::Fast) needed, not picked up
automatically

Nitpick:

- redundant BR: perl
- license text not included; suggest the usual fix
- suggest including CHANGES as %doc
- make called without %{?_smp_mflags}
- BR: perl(Class::Accessor::Chained) should really be
perl(Class::Accessor::Chained::Fast), though the same package provides both
- add BR: perl(Test::Pod) & perl(Test::Pod::Coverage) for improved test cover
Comment 2 Paul Howarth 2005-08-25 07:01:42 EDT
Created attachment 118105 [details]
Patch addressing review issues
Comment 4 Paul Howarth 2005-08-26 04:48:37 EDT
Approved.

Note You need to log in before you can comment on or make changes to this bug.