Bug 166193 - Review Request: perl-Class-DBI-Plugin-RetrieveAll : More complex retrieve_all() for Class::DBI
Review Request: perl-Class-DBI-Plugin-RetrieveAll : More complex retrieve_all...
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Paul Howarth
David Lawrence
Depends On: 166184 166192
Blocks: FE-ACCEPT 166203
  Show dependency treegraph
Reported: 2005-08-17 16:38 EDT by Tom "spot" Callaway
Modified: 2007-11-30 17:11 EST (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2005-09-07 15:02:08 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)
Patch addressing review issues (1.53 KB, patch)
2005-08-31 07:28 EDT, Paul Howarth
no flags Details | Diff

  None (edit)
Description Tom "spot" Callaway 2005-08-17 16:38:11 EDT
Spec Name or Url: 

SRPM Name or Url:


More complex retrieve_all() for Class::DBI

(NOTE: This package is one of the Maypole dependencies)
Comment 1 Paul Howarth 2005-08-31 07:26:58 EDT

- rpmlint clean
- package and spec file naming OK
- package meets guidelines
- license same as perl, matches spec
- spec written in English and legible
- source matches upstream
- builds in mock for FC4 (i386)
- BR's mostly OK
- no locales, libraries, subpackages or pkgconfigs to worry about
- not relocatable
- no directory ownership or permissions issues
- no duplicate files
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime
- no scriptlets


- BR: perl is redundant
- license text not included


- use %{?_smp_mflags} with make in %build
- add BR: perl(DBD::SQLite) for %check

Comment 2 Paul Howarth 2005-08-31 07:28:04 EDT
Created attachment 118293 [details]
Patch addressing review issues
Comment 4 Paul Howarth 2005-09-02 03:04:56 EDT

Note You need to log in before you can comment on or make changes to this bug.