Spec Name or Url: http://www.auroralinux.org/people/spot/review/Maypole/perl-Class-DBI-Plugin-RetrieveAll.spec SRPM Name or Url: http://www.auroralinux.org/people/spot/review/Maypole/perl-Class-DBI-Plugin-RetrieveAll-1.01-2.src.rpm Description: More complex retrieve_all() for Class::DBI (NOTE: This package is one of the Maypole dependencies)
Review: - rpmlint clean - package and spec file naming OK - package meets guidelines - license same as perl, matches spec - spec written in English and legible - source matches upstream - builds in mock for FC4 (i386) - BR's mostly OK - no locales, libraries, subpackages or pkgconfigs to worry about - not relocatable - no directory ownership or permissions issues - no duplicate files - %clean section present and correct - macro usage is consistent - code, not content - no large docs - docs don't affect runtime - no scriptlets Needswork: - BR: perl is redundant - license text not included Nitpick: - use %{?_smp_mflags} with make in %build - add BR: perl(DBD::SQLite) for %check
Created attachment 118293 [details] Patch addressing review issues
-3 covers em all: SRPM: http://www.auroralinux.org/people/spot/review/Maypole/perl-Class-DBI-Plugin-RetrieveAll-1.01-3.src.rpm SPEC: http://www.auroralinux.org/people/spot/review/Maypole/perl-Class-DBI-Plugin-RetrieveAll.spec
Approved.