Spec Name or Url: http://www.auroralinux.org/people/spot/review/Maypole/perl-Class-DBI-Plugin.spec SRPM Name or Url: http://www.auroralinux.org/people/spot/review/Maypole/perl-Class-DBI-Plugin-0.03-2.src.rpm Description: Abstract base class for Class::DBI plugins (NOTE: This package is one of the Maypole dependencies)
Review: - rpmlint clean - package and spec name OK - package meets guidelines - license same as perl, matches spec - spec file written in English and is legible - sources match upstream - package builds OK in mock on FC4 (i386) - no locales, libraries, subpackages or pkgconfigs etc. to worry about - not relocatable - no directory ownership or permissions issues - no duplicate files - %clean section present and correct - macro usage is consistent - code, not content - no large docs - docs don't affect runtime - no scriptlets Nitpick: - BR: perl is redundant - add %{?_smp_mflags} to "make" - add BR: perl(DBD::SQLite) perl(SQL::Abstract) for extra test cover - license text missing; suggest usual fix
Created attachment 118138 [details] Patch addressing review issues
-3 has these items fixed. SRPM: http://www.auroralinux.org/people/spot/review/Maypole/perl-Class-DBI-Plugin-0.03-3.src.rpm SPEC: http://www.auroralinux.org/people/spot/review/Maypole/perl-Class-DBI-Plugin.spec
Approved. Please use "-t" option to "perldoc"; sorry I forgot that in patch.