Bug 1662526 (neuron) - Review Request: neuron - A flexible and powerful simulator of neurons and networks
Summary: Review Request: neuron - A flexible and powerful simulator of neurons and net...
Status: ASSIGNED
Alias: neuron
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
(Show other bugs)
Version: rawhide
Hardware: All Linux
medium
medium
Target Milestone: ---
Assignee: Dominik 'Rathann' Mierzejewski
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Keywords:
: 1249094 (view as bug list)
Depends On:
Blocks: python-pynn fedora-neuro
TreeView+ depends on / blocked
 
Reported: 2018-12-29 10:29 UTC by Ankur Sinha (FranciscoD)
Modified: 2019-01-06 16:05 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed:
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
dominik: fedora-review?


Attachments (Terms of Use)

Description Ankur Sinha (FranciscoD) 2018-12-29 10:29:58 UTC
Spec URL: https://ankursinha.fedorapeople.org/neuron/neuron.spec
SRPM URL: https://ankursinha.fedorapeople.org/neuron/neuron-7.5-1.20181214git5687519.fc29.src.rpm

Description: 
NEURON is a simulation environment for modeling individual neurons and networks
of neurons. It provides tools for conveniently building, managing, and using
models in a way that is numerically sound and computationally efficient. It is
particularly well-suited to problems that are closely linked to experimental
data, especially those that involve cells with complex anatomical and
biophysical properties.

This package is currently built without GUI (iv) support.
It does not include MPI support.



Fedora Account System Username: ankursinha

Comment 1 Ankur Sinha (FranciscoD) 2019-01-02 11:52:44 UTC
*** Bug 1249094 has been marked as a duplicate of this bug. ***

Comment 2 Dominik 'Rathann' Mierzejewski 2019-01-05 22:53:14 UTC
# Let us tell the system where to find the sundials libraries. It is hard coded.
sed -i 's|SUNDIALS_LIBDIRNAMES="${prefix}/lib"|SUNDIALS_LIBDIRNAMES="$MPI_LIB"|' configure.ac

You're doing the above but not module-loading any MPI implementation configuration, nor is any MPI library added to build dependencies.

Could you sort the BuildRequires and put each one on a separate line?

I would use 'rm' to delete Random123 files instead of doing that with a patch. It'd make the patch much smaller.

Comment 3 Ankur Sinha (FranciscoD) 2019-01-06 16:05:00 UTC
Hi Dominik,

Thanks for taking up the review. I've updated the spec/srpm:

* Sun Jan 06 2019 Ankur Sinha <ankursinha AT fedoraproject DOT org> - 7.5-2.20181214git5687519
- Put each BR on different line
- Remove unneeded comment
- Re-do random123 patch to only modify autotools files
- Remove random123 in prep


https://ankursinha.fedorapeople.org/neuron/neuron.spec
https://ankursinha.fedorapeople.org/neuron/neuron-7.5-2.20181214git5687519.fc29.src.rpm


This is a serial (non MPI) build of NEURON. The MPI builds, and python bindings require NEURON to be installed already. Upstream builds them as post-installation hooks. So, I'll package them up as different packages that will require this one as a BR. I've added this as a comment at the start of the spec.

Cheers,
Ankur


Note You need to log in before you can comment on or make changes to this bug.