Spec Name or Url: http://80.55.221.90/~gajownik/linux/RPMS/gajim/gajim.spec SRPM Name or Url: http://80.55.221.90/~gajownik/linux/RPMS/gajim/gajim-0.8-1.src.rpm sha1sum: http://80.55.221.90/~gajownik/linux/RPMS/gajim/sha1sum Description: Gajim is a Jabber client written in PyGTK. The goal of Gajim's developers is to provide a full featured and easy to use xmpp client for the GTK+ users. Gajim does not require GNOME to run, eventhough it exists with it nicely. /* I have one question: is it better to use python packages (gnome-python2-gtkspell;gnome-python2-libegg) to add systray and spell checking functionality or maybe I should compile modules provided in the tarball? */
I have updated the files. Now it's easier to choose whether to use internal or external modules. Links are the same.
It seems to work fine here, except the gajim-remote script: $ gajim-remote --help Traceback (most recent call last): File "gajim-remote.py", line 35, in ? import i18n ImportError: No module named i18n My guess is that it does not work with gajim 0.8 since you pulled it from the trunk. If you can't find a working gajim-remote.py for version 0.8, I'd suggest to simply drop the gajim-remote functionnality.
(In reply to comment #2) > ImportError: No module named i18n Ooops. Updated version is the same place (I haven't incremented release tag). I have just changed this line in the gajim-remote.py file: import i18n to from common import i18n and it works :] BTW is there any possibility to patch for example "Source1" file?
> Updated version is the same place (I haven't incremented release tag) Please do. Always increment the release tag when you make a change, even if the package is never to be published. It makes it a lot easier at least for me, and avoids confusion as to which version is approved. > I have just changed this line in the gajim-remote.py file Don't change upstream sources like this. The objective is to only include sources that are identical to upstream. All modifications must be done inside the spec file, for example in the %prep or %install stage. I would have done this in %install: -install -p -m 0755 %{SOURCE1} %{buildroot}%{_datadir}/gajim/src +perl -p -e 's/^import i18n$/from common import i18n/g' %{SOURCE1} > \ + %{buildroot}%{_datadir}/gajim/src What is the matter with this file ? Did upstream forget to include it with the release ?
(In reply to comment #4) > Please do. Always increment the release tag when you make a change OK, done. Here's the URL â http://80.55.221.90/~gajownik/linux/RPMS/gajim/ > Don't change upstream sources like this. Yes, I know. That's why I've asked about patching other sources :) > -install -p -m 0755 %{SOURCE1} %{buildroot}%{_datadir}/gajim/src > +perl -p -e 's/^import i18n$/from common import i18n/g' %{SOURCE1} > \ > + %{buildroot}%{_datadir}/gajim/src I don't know perl so I used sed. I left line with "install" because rpmlint was complaining about wrong permissions. > What is the matter with this file ? Did upstream forget to include it with the > release ? Hmmm... I don't know. I searched their mailing lists and I haven't found the answer. I've added this file because I thought that it would be better to enhance functionality of gajim â http://trac.gajim.org/wiki/GajimDBus This file is also included in the PLD's rpm â http://cvs.pld-linux.org/cgi-bin/cvsweb/SPECS/gajim.spec?rev=1.15
OK, looks good. Above the Source1 tag, you could add the full URL : http://trac.gajim.org/file/trunk/scripts/gajim-remote.py?rev=3170&format=raw (it won't work inside the source tag because of the query string) Passed: * RPM name * Spec changes look OK * Source gajim-0.8.tar.bz2 is the same as upstream * Source gajim-remote.py is the same as upstream * Patch gajim-0.8.cflags.patch (0) looks OK * Patch gajim-0.8.po.patch (1) looks OK * Patch gajim-0.8.remote.patch (2) looks OK * Patch gajim-0.8.aplay.patch (3) looks OK * The BuildRoot is the preferred one * Spec looks OK * Builds fine * rpmlint looks OK * File list looks OK * Works fine (even with google talk... ;) )
FWIW, I would use the modules that are shipped as part of core instead of compiling them in the package. That'll just work better over time as things change.
(In reply to comment #6) > Above the Source1 tag, you could add the full URL : > http://trac.gajim.org/file/trunk/scripts/gajim-remote.py?rev=3170&format=raw Done. I have had few problems (wrong libdir on x86_64 platform and missing BuildRequires: desktop-file-utils) but it now builds without a glith ;) I have also updated owners.list file. Thanks for the review! (In reply to comment #7) > FWIW, I would use the modules that are shipped as part of core instead of > compiling them in the package. Done. I just wasn't sure what is better: internal modules written in C or external ones written in Python.
(reassigning the bug to myself)
Package Change Request ====================== Package Name: gajim New Branches: EL-4 EL-5 Owners: michich InitialCC: rishi
cvs done.
Package Change Request ====================== Package Name: gajim New Branches: epel7 Owners: michich A user requested Gajim in EPEL 7 in bug 1126898.
Git done (by process-git-requests).