Bug 1664269 - [RFE] Add README to the oVirt.logging role and parameterise the omelasticsearch variables
Summary: [RFE] Add README to the oVirt.logging role and parameterise the omelasticsear...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine-metrics
Classification: oVirt
Component: RFEs
Version: unspecified
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ovirt-4.3.4
: ---
Assignee: Shirly Radco
QA Contact: Ivana Saranova
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-01-08 09:51 UTC by Shirly Radco
Modified: 2019-06-11 06:24 UTC (History)
2 users (show)

Fixed In Version: ovirt-engine-metrics-1.2.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-06-11 06:24:00 UTC
oVirt Team: Metrics
Embargoed:
sradco: ovirt-4.3?
rule-engine: planning_ack?
sradco: devel_ack+
lsvaty: testing_ack+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 96691 0 master MERGED Update logging role facts 2019-01-08 12:35:17 UTC

Description Shirly Radco 2019-01-08 09:51:43 UTC
Description of problem:
Need to add README to the oVirt.logging role and parameterise the omelasticsearch (rsyslog elasticsearch output plugin) variables.

Also, allow setting if to collect metrics / engine / vdsm logs or not.
Default is to collect all.

Comment 1 Ivana Saranova 2019-01-24 14:02:57 UTC
Hi, could you please provide steps to test this? Thank you

Comment 2 Shirly Radco 2019-02-25 13:09:43 UTC
Please review the logging role README file and test the following parameters:

- `collect_ovirt_vdsm_log:` (default: `"true"`)

  By setting this variable to false, vsdm logs will not be collected.

- `collect_ovirt_engine_log:` (default: `"true"`)

  By setting this variable to false, engine logs will not be collected.

- `collect_ovirt_collectd_metrics:` (default: `"true"`)

  By setting this variable to false, Collectd metrics will not be collected.

By setting them false you should be able to configure rsyslog to collect only parts of the data.

But when I think about this more I need to add additional logic to the Collectd role if "collect_ovirt_collectd_metrics" is set to false.
Please check only "collect_ovirt_engine_log" and "collect_ovirt_vdsm_log"

I Opened a separate bug for the "collect_ovirt_collectd_metrics" variable - #1680647

Comment 3 Ivana Saranova 2019-04-05 16:06:31 UTC
Where can I see which logs were collected? Thank you

Comment 4 Shirly Radco 2019-04-05 21:06:18 UTC
I'm sorry, you will not be able to verify the variables at this point due to a bug.
Please only test that the README of the oVirt.linux-system-roles-logging role exists. If it is there then this bug can be verified.

There is an open bug about the variables for not collecting collectd data and the functionality should be tested there. 
Bug #1680647

Comment 5 Ivana Saranova 2019-04-15 14:48:13 UTC
Steps:
1] Go to oVirt.linux-system-roles-logging role folder and check that valid README file is present
2] Check contents of the oVirt.logging role folder and check that these parameters are present:

- `collect_ovirt_vdsm_log:` (default: `"true"`)

  By setting this variable to false, vsdm logs will not be collected.

- `collect_ovirt_engine_log:` (default: `"true"`)

  By setting this variable to false, engine logs will not be collected.

- `collect_ovirt_collectd_metrics:` (default: `"true"`)

  By setting this variable to false, Collectd metrics will not be collected.


Results:
READMEs are in the specified folders and have expected content.

Verified in:
ovirt-engine-4.3.3.3-0.1.el7.noarch
ovirt-engine-metrics-1.3.0.2-1.el7ev.noarch

Comment 6 Sandro Bonazzola 2019-06-11 06:24:00 UTC
This bugzilla is included in oVirt 4.3.4 release, published on June 11th 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.3.4 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.