Bug 1666545 - Review Request: python-qdarkstyle - A dark stylesheet for Qt applications [NEEDINFO]
Summary: Review Request: python-qdarkstyle - A dark stylesheet for Qt applications
Keywords:
Status: ASSIGNED
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1666513
TreeView+ depends on / blocked
 
Reported: 2019-01-15 23:29 UTC by Jonny Heggheim
Modified: 2020-07-10 09:55 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: ---
zebob.m: fedora-review?
package-review: needinfo? (zebob.m)


Attachments (Terms of Use)

Description Jonny Heggheim 2019-01-15 23:29:04 UTC
Spec URL: http://jonny.fedorapeople.org//python-qdarkstyle.spec
SRPM URL: http://jonny.fedorapeople.org//python-qdarkstyle-2.6.5-1.fc29.src.rpm

Description:
A dark stylesheet for Qt applications.

Comment 1 Jonny Heggheim 2019-01-15 23:29:07 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=32052203

Comment 2 Hirotaka Wakabayashi 2019-01-20 12:56:08 UTC
Hello, this is an unofficial review. Please read it for your reference.

Summary:
1. Rpmlint 4 errors, 3 warnings.
2. No files under the CC-BY License are included.
3. No Test suites exist.
4. No python3-setuptools in BuildRequires.

Details:
1. Rpmlint
'/usr/bin/env python' MUST NOT be used in shebang lines.
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_multiple_python_runtimes

python3-qdarkstyle SHOULD contain the manpage of /usr/bin/qdarkstyle.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages

Here is the output of rpmlint on the binary rpm package in my fedora29 environment:
```
python3-qdarkstyle.noarch: W: spelling-error Summary(en_US) stylesheet -> style sheet, style-sheet, stylishness
The value of this tag appears to be misspelled. Please double-check.

python3-qdarkstyle.noarch: W: spelling-error %description -l en_US stylesheet -> style sheet, style-sheet, stylishness
The value of this tag appears to be misspelled. Please double-check.

python3-qdarkstyle.noarch: E: wrong-script-interpreter /usr/lib/python3.7/site-packages/qdarkstyle/__init__.py /usr/bin/env python
This script uses an interpreter which is either an inappropriate one or
located in an inappropriate directory for packaged system software.

python3-qdarkstyle.noarch: E: non-executable-script /usr/lib/python3.7/site-packages/qdarkstyle/__init__.py 644 /usr/bin/env python
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

python3-qdarkstyle.noarch: E: wrong-script-interpreter /usr/lib/python3.7/site-packages/qdarkstyle/__main__.py /usr/bin/env python
This script uses an interpreter which is either an inappropriate one or
located in an inappropriate directory for packaged system software.

python3-qdarkstyle.noarch: E: non-executable-script /usr/lib/python3.7/site-packages/qdarkstyle/__main__.py 644 /usr/bin/env python
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

python3-qdarkstyle.noarch: W: no-manual-page-for-binary qdarkstyle
Each executable in standard binary directories should have a man page.

1 packages and 0 specfiles checked; 4 errors, 3 warnings.
```

2. No file under the CC-BY License.
I think images are distributed under the CC-BY license, but no images are
included. Does this package need to include them? If not, License: field
value should be 'MIT' only because The License: field refers to the licenses
of the contents of the binary rpm.
https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_field

3. No Test suites.
If upstream provides a test suite and it is practical, you should add it
to the %check section.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_test_suites

4. No python3-setuptools in BuildRequires.
upstream uses setuptools to build this package. setuptools is a very common
package, but it is important that your package list all necessary build
dependencies using the BuildRequires: tag.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#buildrequires

Thanks in advance,
Hirotaka Wakabayashi

Comment 3 Robert-André Mauchin 🐧 2019-02-15 23:37:30 UTC
I'll approve this package once Hirotaka Wakabayashi's comments are addressed.

Comment 4 Package Review 2020-07-10 00:57:04 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time, but it seems
that the review is still being working out by you. If this is right, please
respond to this comment clearing the NEEDINFO flag and try to reach out the
submitter to proceed with the review.

If you're not interested in reviewing this ticket anymore, please clear the
fedora-review flag and reset the assignee, so that a new reviewer can take
this ticket.

Without any reply, this request will shortly be resetted.

Comment 5 Jonny Heggheim 2020-07-10 09:55:35 UTC
Sorry, this package was forgotten since it was optional by Electrum and Electron Cash. Would like to include it.


Note You need to log in before you can comment on or make changes to this bug.