Bug 1667406 - Message of ovirt-engine-metrics about requiring a non existent collectd plugin during host-deploy is confusing
Summary: Message of ovirt-engine-metrics about requiring a non existent collectd plugi...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine-metrics
Classification: oVirt
Component: Generic
Version: unspecified
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ovirt-4.3.0
: ---
Assignee: Shirly Radco
QA Contact: Ivana Saranova
URL:
Whiteboard:
Depends On: 1667417
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-01-18 11:48 UTC by Netbulae
Modified: 2019-02-13 07:43 UTC (History)
11 users (show)

Fixed In Version: ovirt-engine-metrics-1.2.0.2
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-02-13 07:43:03 UTC
oVirt Team: Metrics
Embargoed:
rule-engine: ovirt-4.3+
rule-engine: blocker+
lsvaty: testing_ack+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 97233 0 master MERGED Updated initial validations messages 2020-07-12 07:01:53 UTC

Description Netbulae 2019-01-18 11:48:11 UTC
Description of problem:

When trying to upgrade ovirt node rc1 to rc2, I get the following yum errors:

2019-01-17 17:52:32,445 p=14569 u=ovirt |  TASK [oVirt.metrics/roles/oVirt.initial-validations : Check Rsyslog packages are available] ***
2019-01-17 17:52:37,205 p=14569 u=ovirt |  fatal: [node9.netbulae.internal]: FAILED! => {
    "changed": false,
    "rc": 126,
    "results": [
        "rsyslog-8.24.0-34.el7.x86_64 providing rsyslog is already installed",
        "rsyslog-mmnormalize-8.24.0-34.el7.x86_64 providing rsyslog-mmnormalize is already installed",
        "rsyslog-elasticsearch-8.24.0-34.el7.x86_64 providing rsyslog-elasticsearch is already installed",
        "rsyslog-mmjsonparse-8.24.0-34.el7.x86_64 providing rsyslog-mmjsonparse is already installed",
        "libfastjson-0.99.4-3.el7.x86_64 providing libfastjson is already installed",
        "liblognorm-2.0.2-3.el7.x86_64 providing liblognorm is already installed",
        "libestr-0.1.9-2.el7.x86_64 providing libestr is already installed",
        "No package matching 'collectd-write_rsyslog' found available, installed or updated"
    ]
}

MSG:

No package matching 'collectd-write_rsyslog' found available, installed or updated


2019-01-17 17:52:37,206 p=14569 u=ovirt |  ...ignoring
2019-01-17 17:52:37,321 p=14569 u=ovirt |  TASK [oVirt.metrics/roles/oVirt.initial-validations : Set logging_collector as rsyslog] ***
2019-01-17 17:52:37,363 p=14569 u=ovirt |  skipping: [node9.netbulae.internal] => {
    "changed": false,
    "skip_reason": "Conditional result was False"
}
2019-01-17 17:52:37,455 p=14569 u=ovirt |  TASK [oVirt.metrics/roles/oVirt.initial-validations : Check Fluentd packages are available] ***
2019-01-17 17:52:42,323 p=14569 u=ovirt |  fatal: [node9.netbulae.internal]: FAILED! => {
    "changed": false,
    "rc": 126,
    "results": [
        "No package matching 'fluentd' found available, installed or updated"
    ]
}

MSG:

No package matching 'fluentd' found available, installed or updated

2019-01-17 17:52:42,324 p=14569 u=ovirt |  ...ignoring
2019-01-17 17:52:42,435 p=14569 u=ovirt |  TASK [oVirt.metrics/roles/oVirt.initial-validations : Set logging_collector as fluentd] ***
2019-01-17 17:52:42,482 p=14569 u=ovirt |  skipping: [node9.netbulae.internal] => {
    "changed": false,
    "skip_reason": "Conditional result was False"
}
2019-01-17 17:52:42,586 p=14569 u=ovirt |  TASK [oVirt.metrics/roles/oVirt.initial-validations : Validate Fluentd or Rsyslog base packages are available] ***
2019-01-17 17:52:42,711 p=14569 u=ovirt |  changed: [node9.netbulae.internal => {}

MSG:

ERROR Logs collector base packages are not available. Metrics role will not be able to continue

2019-01-17 17:52:42,804 p=14569 u=ovirt |  TASK [oVirt.metrics/roles/oVirt.initial-validations : Validate logging_collector] ***
2019-01-17 17:52:42,918 p=14569 u=ovirt |  changed: [node9.netbulae.internal] => {}

MSG:

ERROR log collector is missing required base packages. Metrics role will not be able to continue

Comment 1 Sandro Bonazzola 2019-01-18 12:19:25 UTC
Collectd is missing write_rsyslog plugin. Pushed a patch here: https://review.rdoproject.org/r/#/c/18398/1

Comment 2 Sandro Bonazzola 2019-01-18 12:23:53 UTC
I'll open a bug on collectd but I can't ensure the patch will be accepted before 4.3.0 GA so a fix in metrics must be prepared for reverting this.

Comment 3 Shirly Radco 2019-01-21 09:25:02 UTC
I don't believe this is a regression for Beta.
The behavior is that if the package is missing rsyslog will not be configured. 
That is acceptable until we have the package for the RHV GA.
 
The "ERROR" in the message is part of my message and not a "real" error.
I'll update the ERROR messages to reflect that this is ONLY metrics error and does not fail host-deploy!
 
I think thus can be lowered in severity and renamed to update ansible messages
to be more descriptive.

Comment 4 Huijuan Zhao 2019-01-21 09:37:41 UTC
I upgrade ovirt node 4.3 rc1 to rc2 successful without the "ERROR" message in Comment 0, not sure what I missed.

Test version:
# imgbase layout
ovirt-node-ng-4.3.0-0.20190110.0
 +- ovirt-node-ng-4.3.0-0.20190110.0+1
ovirt-node-ng-4.3.0-0.20190116.0
 +- ovirt-node-ng-4.3.0-0.20190116.0+1



# yum install ovirt-node-ng-image-update-4.3.0-0.5.rc2.el7.noarch.rpm 
Loaded plugins: enabled_repos_upload, fastestmirror, imgbased-persist, package_upload, product-id, search-disabled-repos, subscription-manager, vdsmupgrade
This system is not registered with an entitlement server. You can use subscription-manager to register.
Repository centos-sclo-rh-release is listed more than once in the configuration
Examining ovirt-node-ng-image-update-4.3.0-0.5.rc2.el7.noarch.rpm: ovirt-node-ng-image-update-4.3.0-0.5.rc2.el7.noarch
Marking ovirt-node-ng-image-update-4.3.0-0.5.rc2.el7.noarch.rpm as an update to ovirt-node-ng-image-update-4.3.0-0.4.rc1.el7.noarch
Resolving Dependencies
--> Running transaction check
---> Package ovirt-node-ng-image-update.noarch 0:4.3.0-0.4.rc1.el7 will be updated
---> Package ovirt-node-ng-image-update.noarch 0:4.3.0-0.5.rc2.el7 will be obsoleting
---> Package ovirt-node-ng-image-update-placeholder.noarch 0:4.3.0-0.4.rc1.el7 will be obsoleted
--> Finished Dependency Resolution

Dependencies Resolved

=========================================================================================================================================================================================
 Package                                      Arch                     Version                              Repository                                                              Size
=========================================================================================================================================================================================
Installing:
 ovirt-node-ng-image-update                   noarch                   4.3.0-0.5.rc2.el7                    /ovirt-node-ng-image-update-4.3.0-0.5.rc2.el7.noarch                   628 M
     replacing  ovirt-node-ng-image-update-placeholder.noarch 4.3.0-0.4.rc1.el7

Transaction Summary
=========================================================================================================================================================================================
Install  1 Package

Total size: 628 M
Is this ok [y/d/N]: y
Downloading packages:
Running transaction check
Running transaction test
Transaction test succeeded
Running transaction
  Installing : ovirt-node-ng-image-update-4.3.0-0.5.rc2.el7.noarch                                                                                                                   1/3 
  Erasing    : ovirt-node-ng-image-update-placeholder-4.3.0-0.4.rc1.el7.noarch                                                                                                       2/3 
  Cleanup    : ovirt-node-ng-image-update-4.3.0-0.4.rc1.el7.noarch                                                                                                                   3/3 
warning: file /usr/share/ovirt-node-ng-image-update/image/ovirt-node-ng-image-update-4.3.0-0.4.rc1.el7.squashfs.img: remove failed: No such file or directory
Uploading Package Profile
Unable to upload Package Profile
centos-opstools-release/x86_64                                                                                                                                    | 2.9 kB  00:00:00     
centos-opstools-release/x86_64/primary_db                                                                                                                         | 352 kB  00:00:00     
centos-ovirt-common-testing/x86_64                                                                                                                                | 3.4 kB  00:00:00     
centos-ovirt-common-testing/x86_64/primary_db                                                                                                                     |  88 kB  00:00:00     
centos-ovirt43-testing/x86_64                                                                                                                                     | 3.4 kB  00:00:00     
centos-ovirt43-testing/x86_64/primary_db                                                                                                                          |  43 kB  00:00:00     
opstools7-common-testing/x86_64                                                                                                                                   | 3.4 kB  00:00:00     
opstools7-common-testing/x86_64/primary_db                                                                                                                        |  20 kB  00:00:00     
opstools7-fluentd-012-testing/x86_64                                                                                                                              | 3.4 kB  00:00:00     
opstools7-fluentd-012-testing/x86_64/primary_db                                                                                                                   |  39 kB  00:00:00     
opstools7-perfmon-common-testing/x86_64                                                                                                                           | 3.4 kB  00:00:00     
opstools7-perfmon-common-testing/x86_64/primary_db                                                                                                                |  42 kB  00:00:00     
ovirt-4.3-centos-gluster5/x86_64                                                                                                                                  | 2.9 kB  00:00:00     
ovirt-4.3-centos-gluster5/x86_64/primary_db                                                                                                                       |  57 kB  00:00:00     
ovirt-4.3-centos-qemu-ev/x86_64                                                                                                                                   | 2.9 kB  00:00:00     
ovirt-4.3-centos-qemu-ev/x86_64/primary_db                                                                                                                        |  54 kB  00:00:00     
ovirt-4.3-epel/x86_64/metalink                                                                                                                                    | 7.7 kB  00:00:00     
ovirt-4.3-epel/x86_64                                                                                                                                             | 4.7 kB  00:00:00     
ovirt-4.3-epel/x86_64/group_gz                                                                                                                                    |  88 kB  00:00:00     
ovirt-4.3-epel/x86_64/updateinfo                                                                                                                                  | 952 kB  00:00:00     
ovirt-4.3-epel/x86_64/primary_db                                                                                                                                  | 6.6 MB  00:00:00     
ovirt-4.3-pre/7                                                                                                                                                   | 3.0 kB  00:00:00     
ovirt-4.3-pre/7/primary_db                                                                                                                                        | 145 kB  00:00:00     
ovirt-4.3-virtio-win-latest                                                                                                                                       | 3.0 kB  00:00:00     
ovirt-4.3-virtio-win-latest/primary_db                                                                                                                            | 6.5 kB  00:00:00     
ovirtwebui-ovirt-web-ui-master/x86_64                                                                                                                             | 3.0 kB  00:00:00     
ovirtwebui-ovirt-web-ui-master/x86_64/primary_db                                                                                                                  | 2.3 kB  00:00:00     
Loading mirror speeds from cached hostfile
 * ovirt-4.2-epel: mirrors.tuna.tsinghua.edu.cn
 * ovirt-4.3-epel: mirrors.tuna.tsinghua.edu.cn
  Verifying  : ovirt-node-ng-image-update-4.3.0-0.5.rc2.el7.noarch                                                                                                                   1/3 
  Verifying  : ovirt-node-ng-image-update-placeholder-4.3.0-0.4.rc1.el7.noarch                                                                                                       2/3 
  Verifying  : ovirt-node-ng-image-update-4.3.0-0.4.rc1.el7.noarch                                                                                                                   3/3 

Installed:
  ovirt-node-ng-image-update.noarch 0:4.3.0-0.5.rc2.el7                                                                                                                                  

Replaced:
  ovirt-node-ng-image-update-placeholder.noarch 0:4.3.0-0.4.rc1.el7                                                                                                                      

Complete!

Comment 5 Shirly Radco 2019-01-21 11:29:01 UTC
The ERROR is for oVirt metrics. The bug is that the host deploy ansible produces "ERROR" messages for ovirt metrics installation.
This is confusing and these and not real ERRORs .
You can ignore and I'll have them fixed.
They do not fail or affect the host deployment.

Comment 6 Netbulae 2019-01-23 15:06:35 UTC
Not only is the ERROR confusing, the engine returns "install failed!" I think; tomorrow I will have time for testing again.

That's why I thought the upgrade from engine failed and checked the ansible logs ;-)

Comment 7 Ivana Saranova 2019-01-31 15:38:07 UTC
Steps:
1) Have a 4.3 engine with 4.3 hosts and working metrics store environment
2) Create a new 4.3 host without collectd and fluentd
3) Add this host to engine (deploy host)
4) Check if host was deployed successsfully

Logs:

2019-01-31 15:49:32,651 p=32547 u=ovirt |  TASK [oVirt.metrics/roles/oVirt.initial-validations : Check Rsyslog packages are available] ***
2019-01-31 15:49:35,178 p=32547 u=ovirt |  fatal: [host_new]: FAILED! => {
    "changed": false,
    "rc": 126,
    "results": [
        "rsyslog-8.24.0-34.el7.x86_64 providing rsyslog is already installed",
        "rsyslog-mmnormalize-8.24.0-34.el7.x86_64 providing rsyslog-mmnormalize is already installed",
        "rsyslog-elasticsearch-8.24.0-34.el7.x86_64 providing rsyslog-elasticsearch is already installed",
        "rsyslog-mmjsonparse-8.24.0-34.el7.x86_64 providing rsyslog-mmjsonparse is already installed",
        "libfastjson-0.99.4-3.el7.x86_64 providing libfastjson is already installed",
        "liblognorm-2.0.2-3.el7.x86_64 providing liblognorm is already installed",
        "libestr-0.1.9-2.el7.x86_64 providing libestr is already installed",
        "No package matching 'collectd-write_syslog' found available, installed or updated"
    ]
}

MSG:

No package matching 'collectd-write_syslog' found available, installed or updated

2019-01-31 15:49:35,179 p=32547 u=ovirt |  ...ignoring
2019-01-31 15:49:35,227 p=32547 u=ovirt |  TASK [oVirt.metrics/roles/oVirt.initial-validations : Set logging_collector as rsyslog] ***
2019-01-31 15:49:35,254 p=32547 u=ovirt |  skipping: [host_new] => {
    "changed": false,
    "skip_reason": "Conditional result was False"
}
2019-01-31 15:49:35,305 p=32547 u=ovirt |  TASK [oVirt.metrics/roles/oVirt.initial-validations : Check Fluentd packages are available] ***
2019-01-31 15:49:59,822 p=32547 u=ovirt |  changed: [host_new] => {
    "changed": true,
    "rc": 0,
    "results": [
        "rubygem-fluent-plugin-secure-forward-0.4.5-1.el7.noarch providing rubygem-fluent-plugin-secure-forward is already installed",
        "Loaded plugins: enabled_repos_upload, package_upload, product-id, search-\n              : disabled-repos, vdsmupgrade\nResolving Dependencies\n--> Running transaction check\n---> Package fluentd.x86_64 0:0.12.42-1.el7 will be installed\n---> Package rubygem-fluent-plugin-collectd-nest.noarch 0:0.1.4-1.el7 will be installed\n---> Package rubygem-fluent-plugin-elasticsearch.noarch 0:1.9.5.1-1.el7 will be installed\n---> Package rubygem-fluent-plugin-rewrite-tag-filter.noarch 0:1.5.6-1.el7 will be installed\n---> Package rubygem-fluent-plugin-viaq_data_model.noarch 0:0.0.13-1.el7 will be installed\n--> Finished Dependency Resolution\n\nDependencies Resolved\n\n================================================================================\n Package            Arch   Version       Repository                        Size\n================================================================================\nInstalling:\n fluentd            x86_64 0.12.42-1.el7 rhel-7-server-rhv-mgmt-agent-x86 435 k\n rubygem-fluent-plugin-collectd-nest\n                    noarch 0.1.4-1.el7   rhel-7-server-rhv-mgmt-agent-ppc 6.7 k\n rubygem-fluent-plugin-elasticsearch\n                    noarch 1.9.5.1-1.el7 rhel-7-server-rhv-mgmt-agent-ppc  18 k\n rubygem-fluent-plugin-rewrite-tag-filter\n                    noarch 1.5.6-1.el7   rhel-7-server-rhv-mgmt-agent-ppc  10 k\n rubygem-fluent-plugin-viaq_data_model\n                    noarch 0.0.13-1.el7  rhel-7-server-rhv-mgmt-agent-ppc  16 k\n\nTransaction Summary\n================================================================================\nInstall  5 Packages\n\nTotal download size: 486 k\nInstalled size: 2.3 M\nDownloading packages:\n--------------------------------------------------------------------------------\nTotal                                              536 kB/s | 486 kB  00:00     \nRunning transaction check\nRunning transaction test\nTransaction test succeeded\nRunning transaction\n  Installing : fluentd-0.12.42-1.el7.x86_64                                 1/5 \n  Installing : rubygem-fluent-plugin-viaq_data_model-0.0.13-1.el7.noarch    2/5 \n  Installing : rubygem-fluent-plugin-elasticsearch-1.9.5.1-1.el7.noarch     3/5 \n  Installing : rubygem-fluent-plugin-collectd-nest-0.1.4-1.el7.noarch       4/5 \n  Installing : rubygem-fluent-plugin-rewrite-tag-filter-1.5.6-1.el7.noarc   5/5 \nUploading Package Profile\n  Verifying  : rubygem-fluent-plugin-viaq_data_model-0.0.13-1.el7.noarch    1/5 \n  Verifying  : fluentd-0.12.42-1.el7.x86_64                                 2/5 \n  Verifying  : rubygem-fluent-plugin-elasticsearch-1.9.5.1-1.el7.noarch     3/5 \n  Verifying  : rubygem-fluent-plugin-collectd-nest-0.1.4-1.el7.noarch       4/5 \n  Verifying  : rubygem-fluent-plugin-rewrite-tag-filter-1.5.6-1.el7.noarc   5/5 \n\nInstalled:\n  fluentd.x86_64 0:0.12.42-1.el7                                                \n  rubygem-fluent-plugin-collectd-nest.noarch 0:0.1.4-1.el7                      \n  rubygem-fluent-plugin-elasticsearch.noarch 0:1.9.5.1-1.el7                    \n  rubygem-fluent-plugin-rewrite-tag-filter.noarch 0:1.5.6-1.el7                 \n  rubygem-fluent-plugin-viaq_data_model.noarch 0:0.0.13-1.el7                   \n\nComplete!\nUploading Enabled Repositories Report\nLoaded plugins: product-id\n"
    ]
}

MSG:

Cannot upload enabled repos report, is this client registered?


2019-01-31 15:49:59,870 p=32547 u=ovirt |  TASK [oVirt.metrics/roles/oVirt.initial-validations : Set logging_collector as fluentd] ***
2019-01-31 15:49:59,998 p=32547 u=ovirt |  ok: [host_new] => {
    "ansible_facts": {
        "logging_collector": "fluentd"
    },
    "changed": false
}
2019-01-31 15:50:00,057 p=32547 u=ovirt |  TASK [oVirt.metrics/roles/oVirt.initial-validations : Validate Fluentd or Rsyslog base packages are available] ***
2019-01-31 15:50:00,087 p=32547 u=ovirt |  skipping: [host_new] => {}
2019-01-31 15:50:00,225 p=32547 u=ovirt |  TASK [oVirt.metrics/roles/oVirt.initial-validations : Validate logging_collector] ***
2019-01-31 15:50:00,294 p=32547 u=ovirt |  skipping: [host_new] => {}
2019-01-31 15:50:00,373 p=32547 u=ovirt |  TASK [oVirt.metrics/roles/oVirt.initial-validations : Validate logging_collector] ***


Result:
Host was deployed successfully.

Verified in: ovirt-engine-4.3.0-0.8.rc2.el7.noarch, ovirt-engine-metrics-1.2.0.3-1.el7ev.noarch

Comment 8 Sandro Bonazzola 2019-02-13 07:43:03 UTC
This bugzilla is included in oVirt 4.3.0 release, published on February 4th 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.3.0 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.