Spec Name or Url: http://ftp.kspei.com/pub/steve/rpms/perl-Apache-Session/perl-Apache-Session.spec SRPM Name or Url: http://ftp.kspei.com/pub/steve/rpms/perl-Apache-Session-1.6-1.src.rpm Description: These modules provide persistent storage for arbitrary data, in arbitrary backing stores. The details of interacting with the backing store are abstracted to make all backing stores behave alike. The programmer simply interacts with a tied hash.
You beat me to this one by four days. ;) Review: Good: - rpmlint checks return nothing - meets naming, packaging guidelines - spec in am. english, legible - source matches upstream - compiles on devel (x86) - no missing, unnecessary BR - no libs, locales, docs, or need for -devel - not relocatable - no duplicate files - permissions ok - clean ok - macro use consistent - code not content - nothing in %doc affects runtime - no need for .desktop Needswork: - License is GPL or Artistic, not just Artistic. - I don't see any reason to conditionalize %check. Just go ahead and run it (and always use the BR) - You probably want to use %{perl_vendorlib}/Apache/ instead of %{perl_vendorlib}/* in %files, otherwise, you won't own the directories that are created. Post a fixed spec file and I'll approve this package.
*** Bug 167753 has been marked as a duplicate of this bug. ***
Oddly, almost every .pm says "Distribute under the Artistic License" while README says "Distribute under the same terms as Perl itself". I saw the line in Session.pm first. So do we call it GPL/Artistic or just Artistic?
Go with what the source says. Might not be a bad idea to point out the discontinuity to upstream, but don't let it hold you back on this package.
(Sorry for the delay. Apparently I forgot to submit this.) Spec URL: http://ftp.kspei.com/pub/steve/rpms/perl-Apache-Session/perl-Apache-Session.spec SRPM URL: http://ftp.kspei.com/pub/steve/rpms/perl-Apache-Session-1.6-2.src.rpm
APPROVED.