Bug 1676830 - libreoffice-voikko packaging is incorrect
Summary: libreoffice-voikko packaging is incorrect
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: libreoffice-voikko
Version: 30
Hardware: All
OS: Linux
unspecified
high
Target Milestone: ---
Assignee: Caolan McNamara
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1716901 1734708 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-02-13 10:48 UTC by Timo Aarnipuro
Modified: 2020-07-30 14:48 UTC (History)
8 users (show)

Fixed In Version: libreoffice-voikko-5.0-5.fc30 libreoffice-voikko-5.0-5.fc31
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-02-01 01:19:51 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Timo Aarnipuro 2019-02-13 10:48:58 UTC
Finnish spell checking in LibreOffice Writer stopped working for me when I upgraded Fedora 28 to 29.

I did some digging on this and it seems that python fails to load SettingsEventHandler:

2019-02-13 12:36:59,588 [CALL,tid 13355]: except  uno->py[0x7f52e82b4898].activate = (com.sun.star.uno.RuntimeException){ (com.sun.star.uno.Exception){ Message = (string)"<class 'ImportError'>: No module named 'SettingsEventHandler' (or 'SettingsEventHandler.SettingsEventHandler' is unknown), traceback follows
  File "/usr/lib64/libreoffice/program/pythonloader.py", line 136, in activate
    mod = self.getModuleFromUrl( locationUrl )
  File "/usr/lib64/libreoffice/program/pythonloader.py", line 103, in getModuleFromUrl
    exec(codeobject, mod.__dict__)
  File "/usr/lib64/libreoffice/share/extensions/voikko.uno.pkg/lovoikko.py", line 15, in <module>
    from SettingsEventHandler import SettingsEventHandler
  File "/usr/lib64/python3.7/site-packages/uno.py", line 428, in _uno_import
    raise uno_import_exc
  File "/usr/lib64/python3.7/site-packages/uno.py", line 350, in _uno_import
    return _builtin_import(name, *optargs, **kwargs)

", Context = (com.sun.star.uno.XInterface)0x0 } }

SettingsEventHandler.py is installed in /usr/lib64/libreoffice/share/extensions/voikko.uno.pkg

Taking a look into /usr/lib64/libreoffice/program/pythonloader.py shows that Libreoffice expects the python files to be under a directory called pythonpath:

    path = unohelper.fileUrlToSystemPath( url+"/pythonpath" );
    if 1 == os.access( encfile( path ), os.F_OK) and not path in sys.path:
        if DEBUG == 1:
            print(b"adding " + encfile( path ) + b" to sys.path")
        sys.path.append( path )

This is also how the files are located in the libreoffice-voikko git repo:
https://github.com/voikko/libreoffice-voikko/tree/master/oxt/pythonpath

Moving the listed .py files under pythonpath makes the spell checking work again.

Comment 1 Jarmo 2019-06-05 05:32:46 UTC
Same issue in Fedora 30.

Comment 2 Ben Cotton 2019-10-31 19:11:21 UTC
This message is a reminder that Fedora 29 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 29 on 2019-11-26.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '29'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 29 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 3 Caolan McNamara 2020-01-23 09:57:44 UTC
The install-unpacked target in the Makefile loses the necessary hierarchy at install

Comment 4 Caolan McNamara 2020-01-23 10:28:31 UTC
https://github.com/voikko/libreoffice-voikko/pull/12 as a proposed fix, hopefully no one will mind if I go ahead and fix this in fedora

Comment 5 Caolan McNamara 2020-01-23 10:40:52 UTC
*** Bug 1716901 has been marked as a duplicate of this bug. ***

Comment 6 Fedora Update System 2020-01-23 10:42:04 UTC
FEDORA-2020-1e246ba88d has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-1e246ba88d

Comment 7 Fedora Update System 2020-01-23 10:42:05 UTC
FEDORA-2020-9ac7c9c92d has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2020-9ac7c9c92d

Comment 8 ricky.tigg 2020-01-23 11:51:19 UTC
*** Bug 1734708 has been marked as a duplicate of this bug. ***

Comment 9 Fedora Update System 2020-01-24 19:47:39 UTC
libreoffice-voikko-5.0-5.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-9ac7c9c92d

Comment 10 Fedora Update System 2020-01-25 08:18:25 UTC
libreoffice-voikko-5.0-5.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-1e246ba88d

Comment 11 Fedora Update System 2020-02-01 01:19:51 UTC
libreoffice-voikko-5.0-5.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.

Comment 12 Fedora Update System 2020-02-02 01:34:32 UTC
libreoffice-voikko-5.0-5.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.

Comment 13 Iiro Laiho 2020-07-30 14:48:21 UTC
Could this also be fixed in RHEL 8?


Note You need to log in before you can comment on or make changes to this bug.