Bug 168187 - Review request: perl-File-Flat - Implements a flat filesystem
Summary: Review request: perl-File-Flat - Implements a flat filesystem
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Paul Howarth
QA Contact: David Lawrence
URL: http://search.cpan.org/dist/File-Flat/
Whiteboard:
Depends On: 167282 167381 168160 168174 168186 168194
Blocks: FE-ACCEPT 168213
TreeView+ depends on / blocked
 
Reported: 2005-09-13 11:10 UTC by Ralf Corsepius
Modified: 2014-01-21 18:05 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2005-09-23 06:22:51 UTC
Type: ---
Embargoed:
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Ralf Corsepius 2005-09-13 11:10:37 UTC
Spec Name or Url:
ftp://packman.iu-bremen.de/fedora/SRPMS/perl-File-Flat.spec

SRPM Name or Url:
ftp://packman.iu-bremen.de/fedora/SRPMS/perl-File-Flat-0.95-1.src.rpm

Description:
File::Flat implements a flat filesystem. A flat filesystem is a filesystem
in which directories do not exist. It provides an abstraction over any
normal filesystem which makes it appear as if directories do not exist.

Comment 1 Paul Howarth 2005-09-19 12:05:25 UTC
Review:

- rpmlint clean
- package and spec naming OK
- license is same as perl, matches spec, text included
- spec file written in English and is legible
- source matches upstream
- builds OK in mock for FC4 (i386)
- BR's look OK
- no locales, libraries, subpackages or pkgconfigs to worry about
- not relocatable
- no duplicate files
- no directory ownership or permissions issues
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime
- no desktop file needed
- no scriptlets

Query:

- where did the specific version dependencies for File::Copy, File::Find and
  IO::File come from? Makefile.PL just seems to check for *any* version of
  these modules rather than specific versions

Approved.


Comment 2 Ralf Corsepius 2005-09-19 13:22:51 UTC
(In reply to comment #1)

> - where did the specific version dependencies for File::Copy, File::Find and
>   IO::File come from? 
Probably a braino + cut'n'pasto on my part - Usually cut'n'paste these checks
logs into the spec and edit them.

Seems as if I added the "currently installed versions the checks reported"
instead of the required versions. To be fixed post-commit.

Comment 3 Lubomir Rintel 2014-01-21 17:52:35 UTC
Package Change Request
======================
Package Name: perl-File-Flat
New Branches: epel7
Owners: lkundrak

The Fedora maintainer (Ralf Corsepius, corsepiu) is not willing to maintain EPEL packages.

Comment 4 Gwyn Ciesla 2014-01-21 18:05:19 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.