Bug 1686753 - Review Request: perl-Class-Measure - Create, compare and convert units of measurement
Summary: Review Request: perl-Class-Measure - Create, compare and convert units of mea...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1686788
TreeView+ depends on / blocked
 
Reported: 2019-03-08 09:16 UTC by Petr Pisar
Modified: 2019-03-11 14:03 UTC (History)
2 users (show)

Fixed In Version: perl-Class-Measure-0.06-1.fc31
Clone Of:
Environment:
Last Closed: 2019-03-11 14:03:02 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2019-03-08 09:16:57 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-Class-Measure/perl-Class-Measure.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Class-Measure/perl-Class-Measure-0.06-1.fc31.src.rpm
Description:
This Perl module allows you to create, compare and convert units of
measurement.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2019-03-08 11:56:06 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Class-Measure-0.06-1.fc30.noarch.rpm | sort | uniq -c
      1 perl(base)
      1 perl(Carp)
      1 perl(Class::Measure)
      1 perl(:MODULE_COMPAT_5.28.1)
      1 perl(overload)
      1 perl(strict)
      1 perl(Sub::Exporter) >= 0.982 
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Class-Measure-0.06-1.fc30.noarch.rpm | sort | uniq -c
      1 perl(Class::Measure) = 0.06
      1 perl-Class-Measure = 0.06-1.fc30
      1 perl(Class::Measure::Length) = 0.06
Binary provides are Ok.

$ rpmlint ./perl-Class-Measure*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

The package looks good.
Approved

Comment 2 Gwyn Ciesla 2019-03-11 13:47:32 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Class-Measure

Comment 3 Petr Pisar 2019-03-11 14:03:02 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.