Bug 1686788 - Review Request: perl-GIS-Distance - Calculate geographic distances
Summary: Review Request: perl-GIS-Distance - Calculate geographic distances
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1686753
Blocks: 1686667 1686841
TreeView+ depends on / blocked
 
Reported: 2019-03-08 10:13 UTC by Petr Pisar
Modified: 2019-03-11 14:37 UTC (History)
2 users (show)

Fixed In Version: perl-GIS-Distance-0.11-2.fc31
Clone Of:
Environment:
Last Closed: 2019-03-11 14:17:05 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2019-03-08 10:13:42 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-GIS-Distance/perl-GIS-Distance.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-GIS-Distance/perl-GIS-Distance-0.11-1.fc31.src.rpm
Description:
This Perl module calculates distances between geographic points on, at the
moment, planet Earth. Various "FORMULAS" are available that provide different
levels of accuracy versus speed.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2019-03-08 12:39:57 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-GIS-Distance-0.11-1.fc30.noarch.rpm | sort | uniq -c
      1 perl(Carp)
      1 perl(Class::Measure::Length)
      1 perl(Const::Fast) >= 0.014
      1 perl(Exporter)
      1 perl(GIS::Distance::Constants)
      1 perl(Math::Trig)
      1 perl(:MODULE_COMPAT_5.28.1)
      1 perl(namespace::clean) >= 0.24
      1 perl(strictures) >= 2
      1 perl(:VERSION) >= 5.8.1
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-GIS-Distance-0.11-1.fc30.noarch.rpm | sort | uniq -c
      1 perl(GIS::Distance) = 0.11
      1 perl-GIS-Distance = 0.11-1.fc30
      1 perl(GIS::Distance::Constants) = 0.11
      1 perl(GIS::Distance::Cosine) = 0.11
      1 perl(GIS::Distance::GreatCircle) = 0.11
      1 perl(GIS::Distance::Haversine) = 0.11
      1 perl(GIS::Distance::MathTrig) = 0.11
      1 perl(GIS::Distance::Polar) = 0.11
      1 perl(GIS::Distance::Vincenty) = 0.11
Binary provides are Ok.

$ rpmlint ./perl-GIS-Distance*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

The package looks good.
Approved

Comment 2 Gwyn Ciesla 2019-03-11 13:49:04 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-GIS-Distance

Comment 3 Petr Pisar 2019-03-11 14:17:05 UTC
Thank you for the review and the repository.

Comment 4 Petr Pisar 2019-03-11 14:37:34 UTC
Bootstrap finished in perl-GIS-Distance-0.11-2.fc31.


Note You need to log in before you can comment on or make changes to this bug.