Spec URL: https://ppisar.fedorapeople.org/perl-GIS-Distance-Fast/perl-GIS-Distance-Fast.spec SRPM URL: https://ppisar.fedorapeople.org/perl-GIS-Distance-Fast/perl-GIS-Distance-Fast-0.10-1.fc31.src.rpm Description: This Perl module reimplements some, but not all, of the formulas that come with GIS::Distance in the C programming language. C code is generally much faster than the Perl equivalent. Fedora Account System Username: ppisar
URL and Source addresses are Ok. Source archive (SHA-256: 4b026ca45329f889a512f5e6f610219b293116aca752d18f981abcc7f4e62631) is original. Ok. Summary verified from lib/GIS/Distance/Fast.pm. Ok. Description verified from lib/GIS/Distance/Fast.pm. Ok. License verified from lib/GIS/Distance/Fast.pm and README.md. Ok. XS code, BuildArch is Ok. $ rpmlint perl-GIS-Distance-Fast.spec review-perl-GIS-Distance-Fast/results/perl-GIS-Distance-Fast-0.10-1.fc31.src.rpm review-perl-GIS-Distance-Fast/results/perl-GIS-Distance-Fast-0.10-1.fc31.x86_64.rpm perl-GIS-Distance-Fast.src: W: spelling-error %description -l en_US reimplements -> re implements, re-implements, implements perl-GIS-Distance-Fast.x86_64: W: spelling-error %description -l en_US reimplements -> re implements, re-implements, implements 2 packages and 1 specfiles checked; 0 errors, 2 warnings. $ rpm -q -lv -p perl-GIS-Distance-Fast-0.10-1.fc31.x86_64.rpm drwxr-xr-x 2 root root 0 mars 8 17:15 /usr/lib/.build-id drwxr-xr-x 2 root root 0 mars 8 17:15 /usr/lib/.build-id/4d lrwxrwxrwx 1 root root 70 mars 8 17:15 /usr/lib/.build-id/4d/d33a433614dce6fa66541a2499bdf9fb2a05a8 -> ../../../../usr/lib64/perl5/vendor_perl/auto/GIS/Distance/Fast/Fast.so drwxr-xr-x 2 root root 0 mars 8 17:15 /usr/lib64/perl5/vendor_perl/GIS drwxr-xr-x 2 root root 0 mars 8 17:15 /usr/lib64/perl5/vendor_perl/GIS/Distance drwxr-xr-x 2 root root 0 mars 8 17:15 /usr/lib64/perl5/vendor_perl/GIS/Distance/Fast -rw-r--r-- 1 root root 1327 mars 8 00:17 /usr/lib64/perl5/vendor_perl/GIS/Distance/Fast.pm -rw-r--r-- 1 root root 729 mars 8 00:17 /usr/lib64/perl5/vendor_perl/GIS/Distance/Fast/Cosine.pm -rw-r--r-- 1 root root 750 mars 8 00:17 /usr/lib64/perl5/vendor_perl/GIS/Distance/Fast/Haversine.pm -rw-r--r-- 1 root root 902 mars 8 00:17 /usr/lib64/perl5/vendor_perl/GIS/Distance/Fast/Vincenty.pm drwxr-xr-x 2 root root 0 mars 8 17:15 /usr/lib64/perl5/vendor_perl/auto/GIS drwxr-xr-x 2 root root 0 mars 8 17:15 /usr/lib64/perl5/vendor_perl/auto/GIS/Distance drwxr-xr-x 2 root root 0 mars 8 17:15 /usr/lib64/perl5/vendor_perl/auto/GIS/Distance/Fast -rwxr-xr-x 1 root root 20600 mars 8 17:15 /usr/lib64/perl5/vendor_perl/auto/GIS/Distance/Fast/Fast.so drwxr-xr-x 2 root root 0 mars 8 17:15 /usr/share/doc/perl-GIS-Distance-Fast -rw-r--r-- 1 root root 1120 mars 8 00:17 /usr/share/doc/perl-GIS-Distance-Fast/Changes -rw-r--r-- 1 root root 1261 mars 8 00:17 /usr/share/doc/perl-GIS-Distance-Fast/README.md drwxr-xr-x 2 root root 0 mars 8 17:15 /usr/share/licenses/perl-GIS-Distance-Fast -rw-r--r-- 1 root root 18421 mars 8 00:17 /usr/share/licenses/perl-GIS-Distance-Fast/LICENSE -rw-r--r-- 1 root root 1592 mars 8 17:15 /usr/share/man/man3/GIS::Distance::Fast.3pm.gz -rw-r--r-- 1 root root 1284 mars 8 17:15 /usr/share/man/man3/GIS::Distance::Fast::Cosine.3pm.gz -rw-r--r-- 1 root root 1287 mars 8 17:15 /usr/share/man/man3/GIS::Distance::Fast::Haversine.3pm.gz -rw-r--r-- 1 root root 1367 mars 8 17:15 /usr/share/man/man3/GIS::Distance::Fast::Vincenty.3pm.gz File permissions and layout are Ok. $ rpm -q --requires -p perl-GIS-Distance-Fast-0.10-1.fc31.x86_64.rpm | sort -f | uniq -c 1 libm.so.6()(64bit) 1 libm.so.6(GLIBC_2.2.5)(64bit) 1 libperl.so.5.28()(64bit) 1 libpthread.so.0()(64bit) 1 libpthread.so.0(GLIBC_2.2.5)(64bit) 1 perl(:MODULE_COMPAT_5.28.1) 1 perl(:VERSION) >= 5.8.1 1 perl(GIS::Distance::Constants) >= 0.11 1 perl(GIS::Distance::Fast) 1 perl(namespace::clean) >= 0.24 1 perl(strictures) >= 2 1 perl(XSLoader) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 1 rtld(GNU_HASH) Binary requires are Ok. $ rpm -q --provides -p perl-GIS-Distance-Fast-0.10-1.fc31.x86_64.rpm perl(GIS::Distance::Fast) = 0.10 perl(GIS::Distance::Fast::Cosine) = 0.10 perl(GIS::Distance::Fast::Haversine) = 0.10 perl(GIS::Distance::Fast::Vincenty) = 0.10 perl-GIS-Distance-Fast = 0.10-1.fc31 perl-GIS-Distance-Fast(x86-64) = 0.10-1.fc31 Binary provides are Ok. Package builds in Mock. Ok Resolution: Package approved.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-GIS-Distance-Fast
Thank you for the review and the repository.