Bug 1688292 - Review Request: perl-Geo-Proj4 - Perl binding to PROJ.4 cartographic projections library
Summary: Review Request: perl-Geo-Proj4 - Perl binding to PROJ.4 cartographic projecti...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1688300
TreeView+ depends on / blocked
 
Reported: 2019-03-13 13:20 UTC by Petr Pisar
Modified: 2019-03-14 10:15 UTC (History)
2 users (show)

Fixed In Version: perl-Geo-Proj4-1.09-1.fc31
Clone Of:
Environment:
Last Closed: 2019-03-14 10:15:27 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2019-03-13 13:20:26 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-Geo-Proj4/perl-Geo-Proj4.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Geo-Proj4/perl-Geo-Proj4-1.09-1.fc31.src.rpm
Description:
This package provides a Perl interface to PROJ.4 cartographic projections
library.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2019-03-13 14:49:55 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Geo-Proj4-1.09-1.fc31.x86_64.rpm | sort | uniq -c | grep -v rpmlib
      1 libc.so.6()(64bit)
      1 libc.so.6(GLIBC_2.2.5)(64bit) 
      1 libperl.so.5.28()(64bit)
      1 libproj.so.13()(64bit) 
      1 libpthread.so.0()(64bit)
      1 libpthread.so.0(GLIBC_2.2.5)(64bit)
      1 perl(base)
      1 perl(Carp)
      1 perl(DynaLoader)
      1 perl(:MODULE_COMPAT_5.28.1)
      1 perl(Scalar::Util)
      1 perl(strict)
      1 perl(vars)
      1 perl(warnings)
      1 rtld(GNU_HASH)
Binary requires are Ok.

$ rpm -qp --provides perl-Geo-Proj4-1.09-1.fc31.x86_64.rpm | sort | uniq -c
      1 perl(Geo::Proj4) = 1.09
      1 perl-Geo-Proj4 = 1.09-1.fc31
      1 perl-Geo-Proj4(x86-64) = 1.09-1.fc31
Binary provides are Ok.

$ rpmlint ./perl-Geo-Proj4*
perl-Geo-Proj4.src: W: invalid-license Artistic
perl-Geo-Proj4.x86_64: W: invalid-license Artistic
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
Rpmlint is ok

The package looks good.
Approved

Comment 2 Igor Raits 2019-03-14 09:25:21 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Geo-Proj4

Comment 3 Petr Pisar 2019-03-14 10:15:27 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.