Bug 1692367 - python-smartcols FTBFS with pytest 4.3
Summary: python-smartcols FTBFS with pytest 4.3
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: python-smartcols
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ---
Assignee: Igor Raits
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PYTEST4 PYTHON38
TreeView+ depends on / blocked
 
Reported: 2019-03-25 13:01 UTC by Miro Hrončok
Modified: 2019-07-09 14:52 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-07-09 14:52:07 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
build.log from copr (15.58 KB, text/plain)
2019-03-25 13:01 UTC, Miro Hrončok
no flags Details
root.log from copr (46.70 KB, text/plain)
2019-03-25 13:02 UTC, Miro Hrončok
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Github ignatenkobrain python-smartcols pull 20 0 None None None 2019-04-24 16:13:48 UTC
Red Hat Bugzilla 1675790 0 unspecified CLOSED python-smartcols: FTBFS in Fedora rawhide/f30 2021-02-22 00:41:40 UTC

Description Miro Hrončok 2019-03-25 13:01:03 UTC
Created attachment 1547688 [details]
build.log from copr

With new pytest, the tests of python-smartcols fail with:

/usr/lib/python3.8/site-packages/pluggy/hooks.py:289: in __call__
    return self._hookexec(self, self.get_hookimpls(), kwargs)
/usr/lib/python3.8/site-packages/pluggy/manager.py:68: in _hookexec
    return self._inner_hookexec(hook, methods, kwargs)
/usr/lib/python3.8/site-packages/pluggy/manager.py:59: in <lambda>
    self._inner_hookexec = lambda hook, methods, kwargs: hook.multicall(
/usr/lib/python3.8/site-packages/_pytest/python.py:226: in pytest_pycollect_makeitem
    res = list(collector._genfunctions(name, obj))
/usr/lib/python3.8/site-packages/_pytest/python.py:403: in _genfunctions
    self.ihook.pytest_generate_tests(metafunc=metafunc)
/usr/lib/python3.8/site-packages/pluggy/hooks.py:289: in __call__
    return self._hookexec(self, self.get_hookimpls(), kwargs)
/usr/lib/python3.8/site-packages/pluggy/manager.py:68: in _hookexec
    return self._inner_hookexec(hook, methods, kwargs)
/usr/lib/python3.8/site-packages/pluggy/manager.py:59: in <lambda>
    self._inner_hookexec = lambda hook, methods, kwargs: hook.multicall(
/usr/lib/python3.8/site-packages/_pytest/python.py:133: in pytest_generate_tests
    metafunc.parametrize(*marker.args, **marker.kwargs)
/usr/lib/python3.8/site-packages/_pytest/python.py:990: in parametrize
    argnames, parameters = ParameterSet._for_parametrize(
/usr/lib/python3.8/site-packages/_pytest/mark/structures.py:114: in _for_parametrize
    if len(param.values) != len(argnames):
E   TypeError: object of type 'MarkDecorator' has no len()

This is most likely because the deprecated and now removed support from marking parameters directly with markers.



This is the last bit of previous build log, with the deprecation visible:

arameters is deprecated, please use pytest.param(..., marks=...) instead.
  For more details, see: https://docs.pytest.org/en/latest/parametrize.html
    @pytest.mark.parametrize("name, args", [
-- Docs: https://docs.pytest.org/en/latest/warnings.html
========== 18 passed, 6 xfailed, 3 warnings, 15 error in 1.34 seconds ==========


When this is solved, the previous FTBFS with tests failures need to be solved as well.

Comment 1 Miro Hrončok 2019-03-25 13:02:45 UTC
Created attachment 1547689 [details]
root.log from copr

Comment 4 Miro Hrončok 2019-07-09 14:52:07 UTC
I've merged that PR myself.


Note You need to log in before you can comment on or make changes to this bug.