Spec Name or Url: http://www.cora.nwra.com/~orion/fedora/perl-Cflow.spec SRPM Name or Url: http://www.cora.nwra.com/~orion/fedora/perl-Cflow-1.053-1.src.rpm Description: Cflow with flow-tools support. This module implements an API for processing IP flow accounting information which as been collected from routers and written into flow files.
Review: - rpmlint clean - package and spec naming OK - package meets guidelines - license is GPL, matches spec, text included - spec file written in English and is legible - sources match upstream - package builds OK on FC4 (i386) - BR's mostly OK - no locales, libraries, subpackages or pkgconfigs to worry about - not relocatable - no directory ownership or permissions problems - no duplicate files - %clean section present and correct - macro usage is consistent - code, not content - no large docs - docs don't affect runtime - no desktop entry needed - no scriptlets - package gives impression of running OK (flowdumper -h works as expected) Nitpick: - please capitalize the first letter of Summary: - BR: perl is redundant as perl is a dep of rpm-build Suggestion: - package currently fails to build in mock due to Bug 171206 you could work around this for now by adding a BR of zlib-devel Approved.
Build on devel succeeded.