Created attachment 1566311 [details] issue.png Description of problem: Need option/button to remove conversion host from UI when it is failed to configured Version-Release number of selected component (if applicable): 5.10.4.2.20190508174256_282f74e How reproducible: 100% Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info:
*** Bug 1713032 has been marked as a duplicate of this bug. ***
This is an enhancement that requires API changes. Currently there is no way to persist via the API the fact that a failed MiqTask has been acknowledged/dismissed by the user. Without this persistence there is no way for the UI to hide a failed task without it reappearing on page reload. (The only reason a retry hides the original failure is because the list only shows the most recent enablement task per resource, and retrying creates a new enablement task that takes precedence.) I implemented a similar user-acknowledged-failure feature for migration plan requests because I could persist arbitrary key/value pairs in the options hash on that object, but no such free-form hash exists on MiqTask. We could possibly store this state as a property in a task's context_data, but I would still need an API endpoint I can use to update that value.
*** Bug 1718733 has been marked as a duplicate of this bug. ***
Since this requires an API change, I move it to 5.11.
Fabien, based on discussion with Dan, I need to investigate but this may not require an API change after all. I may not be able to get it done for 5.10.7 but perhaps it can be in 5.10.8. I'll get back to you.
I keep the target release to 5.11 and we can still backport it to 5.10.z whenever it's ready.
@mike, any news on this ?
Fabien, I have not addressed this yet because I have been busy with Migration Analytics and Warm Migration. It's on my backlog.. how high priority do you think this is? Do we need to get it in for the 5.11 code freeze on August 12th? I will try to address it ASAP.
Mike, any idea when this could be implemented?
This has been on my back burner for quite a while, I was planning to finish it after warm migration was done and then never picked it up when warm migration was delayed. Now that I'm focused on IMS again, I'll put it back in my queue. I may have time to get it done by Friday depending on how wrapping up warm migration goes. If not I can definitely get it done for 5.11.6.
Hey Fabien, just copying a question here from Gitter so we don't lose track of it: I'm trying to remember how we decided I can set an arbitrary property on the task object. I remember we determined that was how to solve it, but I'm trying this: POST /api/tasks/42000000000050 { "action": "edit", "resource": { "options": { "user_acknowledged_failure": true } } } and getting this error: { "error": { "kind": "bad_request", "message": "Unsupported Action edit for the tasks resource specified", "klass": "Api::BadRequestError" } } I'm probably forgetting something, but if you have a chance this week would you mind taking a look with me?
https://github.com/ManageIQ/manageiq-v2v/pull/1124
New commit detected on ManageIQ/manageiq-v2v/ivanchuk: https://github.com/ManageIQ/manageiq-v2v/commit/3c85583b9c149f910319383eeb26443df82d791c commit 3c85583b9c149f910319383eeb26443df82d791c Author: Milan Zázrivec <mzazrivec> AuthorDate: Tue Apr 7 08:25:25 2020 +0000 Commit: Milan Zázrivec <mzazrivec> CommitDate: Tue Apr 7 08:25:25 2020 +0000 Merge pull request #1124 from mturley/bz1708367-remove-failed-conv-host [#900][BZ#1708367] Allow removal of a failed conversion host configuration task (cherry picked from commit 00ad97027cff8f882b1ad40441469b9bc86ff094) https://bugzilla.redhat.com/show_bug.cgi?id=1708367 app/javascript/react/screens/App/Settings/SettingsActions.js | 12 +- app/javascript/react/screens/App/Settings/__tests__/SettingsActions.test.js | 8 +- app/javascript/react/screens/App/Settings/helpers.js | 2 +- app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/ConversionHostsSettings.js | 4 - app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/__tests__/__snapshots__/index.test.js.snap | 1 - app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/components/ConversionHostRemoveButton.js | 13 +- app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/components/ConversionHostsList.js | 3 - app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/components/ConversionHostsListItem.js | 18 +- app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/components/DeleteConversionHostConfirmationModal.js | 8 +- app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/components/__tests__/ConversionHostRemoveButton.test.js | 8 +- app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/components/__tests__/ConversionHostsList.test.js | 1 - app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/components/__tests__/DeleteConversionHostConfirmationModal.test.js | 3 +- app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/components/__tests__/__snapshots__/ConversionHostsList.test.js.snap | 1 - app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/components/__tests__/__snapshots__/ConversionHostsListItem.test.js.snap | 79 +- 14 files changed, 109 insertions(+), 52 deletions(-)
New commit detected on ManageIQ/manageiq-v2v/jansa: https://github.com/ManageIQ/manageiq-v2v/commit/7904a7d89fc8bf276cb61e9e95626bca795ccff7 commit 7904a7d89fc8bf276cb61e9e95626bca795ccff7 Author: Milan Zázrivec <mzazrivec> AuthorDate: Tue Apr 7 08:25:25 2020 +0000 Commit: Milan Zázrivec <mzazrivec> CommitDate: Tue Apr 7 08:25:25 2020 +0000 Merge pull request #1124 from mturley/bz1708367-remove-failed-conv-host [#900][BZ#1708367] Allow removal of a failed conversion host configuration task (cherry picked from commit 00ad97027cff8f882b1ad40441469b9bc86ff094) https://bugzilla.redhat.com/show_bug.cgi?id=1708367 app/javascript/react/screens/App/Settings/SettingsActions.js | 12 +- app/javascript/react/screens/App/Settings/__tests__/SettingsActions.test.js | 8 +- app/javascript/react/screens/App/Settings/helpers.js | 2 +- app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/ConversionHostsSettings.js | 4 - app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/__tests__/__snapshots__/index.test.js.snap | 1 - app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/components/ConversionHostRemoveButton.js | 13 +- app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/components/ConversionHostsList.js | 3 - app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/components/ConversionHostsListItem.js | 18 +- app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/components/DeleteConversionHostConfirmationModal.js | 8 +- app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/components/__tests__/ConversionHostRemoveButton.test.js | 8 +- app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/components/__tests__/ConversionHostsList.test.js | 1 - app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/components/__tests__/DeleteConversionHostConfirmationModal.test.js | 3 +- app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/components/__tests__/__snapshots__/ConversionHostsList.test.js.snap | 1 - app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/components/__tests__/__snapshots__/ConversionHostsListItem.test.js.snap | 79 +- 14 files changed, 109 insertions(+), 52 deletions(-)
Verified in 5.11.5
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2020:2020