RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1712946 - qemu-kvm build is broken due to spice_qxl_set_max_monitors being deprecated
Summary: qemu-kvm build is broken due to spice_qxl_set_max_monitors being deprecated
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: qemu-kvm
Version: 8.1
Hardware: Unspecified
OS: Unspecified
high
unspecified
Target Milestone: rc
: 8.0
Assignee: Danilo de Paula
QA Contact: Guo, Zhiyi
URL:
Whiteboard:
Depends On:
Blocks: 1712947
TreeView+ depends on / blocked
 
Reported: 2019-05-22 14:46 UTC by Danilo de Paula
Modified: 2019-11-05 20:50 UTC (History)
5 users (show)

Fixed In Version: qemu-kvm-2.12.0-75.module+el8.1.0+3252+aa5f0857
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1712947 (view as bug list)
Environment:
Last Closed: 2019-11-05 20:50:11 UTC
Type: Bug
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2019:3345 0 None None None 2019-11-05 20:50:50 UTC

Description Danilo de Paula 2019-05-22 14:46:52 UTC
Trying to build qemu-kvm and it failed with the following message:
hw/display/qxl.c: In function 'qxl_spice_monitors_config_async':
hw/display/qxl.c:280:13: error: 'spice_qxl_set_max_monitors' is deprecated [-Werror=deprecated-declarations]
             spice_qxl_set_max_monitors(&qxl->ssd.qxl, qxl->max_outputs);
             ^~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/spice-server/spice.h:26,
                 from /builddir/build/BUILD/qemu-2.12.0/include/ui/qemu-spice.h:25,
                 from hw/display/qxl.h:11,
                 from hw/display/qxl.c:33:
/usr/include/spice-server/spice-qxl.h:105:6: note: declared here
 void spice_qxl_set_max_monitors(QXLInstance *instance,
      ^~~~~~~~~~~~~~~~~~~~~~~~~~

I didn't look into this very deeply, but looks like spice deprecated one of the functions we use in RHEL-8.1.0, making qemu-kvm for RHEL-8.1.0 and RHEL-AV-8.1.0 unbuildable.

Good news is that this has been fixed upstream, but we need to apply this ASAP.


commit be812c0ab7d5ab741d0d87387a75a0e8bb6461e7
Author: Lukáš Hrázký <lhrazky>
Date:   Fri Feb 15 16:09:19 2019 +0100
spice: set device address and device display ID in QXL interface

Comment 1 Danilo de Paula 2019-05-22 20:14:21 UTC
Looks like the following commit is also necessary:

commit 2728a57a061af92b476f926b7fb66cb3ac60ab50 
Author: Philippe Mathieu-Daudé <f4bug>
Date:   Wed Oct 10 23:53:55 2018 +0200          
                                                
    hw/pci: Add missing include

Comment 3 Danilo de Paula 2019-05-22 20:28:00 UTC
QA_ACK, please?

Comment 4 Danilo de Paula 2019-05-24 16:17:15 UTC
Fix included in qemu-kvm-2.12.0-75.module+el8.1.0+3252+aa5f0857

Comment 6 Guo, Zhiyi 2019-07-17 06:12:49 UTC
Hi Danilo,

   Can I mark this bug verified directly since the qemu pkgs have been built successfully? Seems this bug only impact to the build progress, function testing against qemu with multiple displays enabled doesn't have abnormal issues.


BR/
Zhiyi, Guo

Comment 7 Danilo de Paula 2019-07-25 03:18:47 UTC
Yes!

Comment 8 Guo, Zhiyi 2019-08-01 05:17:47 UTC
Verified per comment 6 & 7

Comment 10 errata-xmlrpc 2019-11-05 20:50:11 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2019:3345


Note You need to log in before you can comment on or make changes to this bug.