Bug 1712947 - qemu-kvm build is broken due to spice_qxl_set_max_monitors being deprecated
Summary: qemu-kvm build is broken due to spice_qxl_set_max_monitors being deprecated
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Red Hat Enterprise Linux Advanced Virtualization
Classification: Red Hat
Component: qemu-kvm
Version: 8.1
Hardware: Unspecified
OS: Unspecified
high
unspecified
Target Milestone: rc
: 8.0
Assignee: Ademar Reis
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On: 1712946
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-05-22 14:49 UTC by Danilo de Paula
Modified: 2019-05-22 19:57 UTC (History)
4 users (show)

Fixed In Version: qemu-4.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1712946
Environment:
Last Closed: 2019-05-22 19:57:04 UTC
Type: Bug
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)

Description Danilo de Paula 2019-05-22 14:49:20 UTC 
+++ This bug was initially created as a clone of Bug #1712946 +++

Trying to build qemu-kvm and it failed with the following message:
hw/display/qxl.c: In function 'qxl_spice_monitors_config_async':
hw/display/qxl.c:280:13: error: 'spice_qxl_set_max_monitors' is deprecated [-Werror=deprecated-declarations]
             spice_qxl_set_max_monitors(&qxl->ssd.qxl, qxl->max_outputs);
             ^~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/spice-server/spice.h:26,
                 from /builddir/build/BUILD/qemu-2.12.0/include/ui/qemu-spice.h:25,
                 from hw/display/qxl.h:11,
                 from hw/display/qxl.c:33:
/usr/include/spice-server/spice-qxl.h:105:6: note: declared here
 void spice_qxl_set_max_monitors(QXLInstance *instance,
      ^~~~~~~~~~~~~~~~~~~~~~~~~~

I didn't look into this very deeply, but looks like spice deprecated one of the functions we use in RHEL-8.1.0, making qemu-kvm for RHEL-8.1.0 and RHEL-AV-8.1.0 unbuildable.

Good news is that this has been fixed upstream, but we need to apply this ASAP.


commit be812c0ab7d5ab741d0d87387a75a0e8bb6461e7
Author: Lukáš Hrázký <lhrazky>
Date:   Fri Feb 15 16:09:19 2019 +0100
spice: set device address and device display ID in QXL interface
Comment 1 Ademar Reis 2019-05-22 19:30:18 UTC 
(In reply to Danilo Cesar de Paula from comment #0)
> +++ This bug was initially created as a clone of Bug #1712946 +++
> 
> Trying to build qemu-kvm and it failed with the following message:
> hw/display/qxl.c: In function 'qxl_spice_monitors_config_async':
> hw/display/qxl.c:280:13: error: 'spice_qxl_set_max_monitors' is deprecated
> [-Werror=deprecated-declarations]
>              spice_qxl_set_max_monitors(&qxl->ssd.qxl, qxl->max_outputs);
>              ^~~~~~~~~~~~~~~~~~~~~~~~~~
> In file included from /usr/include/spice-server/spice.h:26,
>                  from
> /builddir/build/BUILD/qemu-2.12.0/include/ui/qemu-spice.h:25,
>                  from hw/display/qxl.h:11,
>                  from hw/display/qxl.c:33:
> /usr/include/spice-server/spice-qxl.h:105:6: note: declared here
>  void spice_qxl_set_max_monitors(QXLInstance *instance,
>       ^~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> I didn't look into this very deeply, but looks like spice deprecated one of
> the functions we use in RHEL-8.1.0, making qemu-kvm for RHEL-8.1.0 and
> RHEL-AV-8.1.0 unbuildable.
> 
> Good news is that this has been fixed upstream, but we need to apply this
> ASAP.
> 
> 
> commit be812c0ab7d5ab741d0d87387a75a0e8bb6461e7
> Author: Lukáš Hrázký <lhrazky>
> Date:   Fri Feb 15 16:09:19 2019 +0100
> spice: set device address and device display ID in QXL interface

This patch is in QEMU-4.0, so marking it POST.
Comment 2 Danilo de Paula 2019-05-22 19:57:04 UTC 
This report is misleading.

I cloned imagining this would happen in RHEL-AV. It doesn't.
I will close this.
Note You need to log in before you can comment on or make changes to this bug.