Bug 171541 - Review Request: kimdaba: KDE Image Database
Summary: Review Request: kimdaba: KDE Image Database
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
(Show other bugs)
Version: rawhide
Hardware: All Linux
Target Milestone: ---
Assignee: Aurelien Bompard
QA Contact: David Lawrence
URL: http://ktown.kde.org/kimdaba/
Depends On:
TreeView+ depends on / blocked
Reported: 2005-10-22 18:02 UTC by Rex Dieter
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2005-10-23 16:07:27 UTC
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)

Description Rex Dieter 2005-10-22 18:02:56 UTC
Spec Name or Url: http://apt.kde-redhat.org/apt/kde-redhat/SPECS/kimdaba-2.1-2.spec
SRPM Name or Url: http://apt.kde-redhat.org/apt/kde-redhat/all/SRPMS.stable/kimdaba-2.1-2.src.rpm
An image database tool.  KimDaBa focuses on three key points:
  * It must be easy to describe a number of images at a time.
  * It must be easy to search for images.
  * It must be easy to browse and View the images.

Can (optionally) use kipi-plugins

Comment 1 Aurelien Bompard 2005-10-22 21:03:32 UTC
Needs work:
* rpmlint of kimdaba: Applications/Graphics (should be Applications/Multimedia,
like digikam)
* The package should contain the text of the license (COPYING file)
  (wiki: PackageReviewGuidelines)
* Missing dependancy on update-desktop-database for %post and %postun (in
package desktop-file-utils)
* as for other recent packages:
  * remove debug_package test on make install
  * enable gtk-update-icon-cache in scriptlets
* looks like you're getting rid of kde-redhat specific tags in CVS, please do it
here too. (dist tag and BRs)

Comment 2 Rex Dieter 2005-10-22 21:12:58 UTC
* Sat Oct 22 2005 Rex Dieter <rexdieter[AT]users.sf.net> 2.1-3
- %%doc: COPYING
- Req(post,postun): update-desktop-database
- gtk-update-icon-cache
- remove unused crud (kde-redhat bits)
- Group: Applications/Multimedia
- drop %%{?debug_package} conditionals

Spec Name or Url: http://apt.kde-redhat.org/apt/kde-redhat/SPECS/kimdaba-2.1-3.spec
SRPM Name or Url:

Comment 3 Aurelien Bompard 2005-10-22 21:39:11 UTC
Why drop Application in the desktop file category ? From
http://fedoraproject.org/wiki/Extras/FedoraDesktopEntryGuidelines :
« All Categories must be from the standard set (see below), with the exception
that the "Application" category should be included where appropriate (ie. for
everything that is supposed to be shown in the menus) for backwards
compatibility even though it is not listed as a standard category. »

Comment 4 Rex Dieter 2005-10-22 21:52:15 UTC
crap, I knew there was a reason to keep Application, even if it wasn't mentioned
in the spec.

Comment 5 Aurelien Bompard 2005-10-22 21:57:06 UTC
Yeah, it looks like it's needed for the "Other" submenu :
/etc/xdg/menus/applications.menu, and possibly elsewhere.

Comment 6 Rex Dieter 2005-10-22 21:58:39 UTC
* Sat Oct 22 2005 Rex Dieter <rexdieter[AT]users.sf.net> 2.1-4
- --add-category Application

Spec Name or Url: http://apt.kde-redhat.org/apt/kde-redhat/SPECS/kimdaba-2.1-4.spec
SRPM Name or Url:

Comment 8 Aurelien Bompard 2005-10-23 08:13:07 UTC
Review for release 4:
* RPM name is OK
* Source kimdaba-2.1.tar.bz2 is the same as upstream
* This is the latest version
* Builds fine in mock
* rpmlint of kimdaba looks OK
* File list of kimdaba looks OK
* Works fine

Comment 9 Rex Dieter 2006-07-06 14:29:25 UTC
FYI, name deprecated, package renamed upstream to kphotoalbum.

Note You need to log in before you can comment on or make changes to this bug.