Red Hat Bugzilla – Bug 171541
Review Request: kimdaba: KDE Image Database
Last modified: 2007-11-30 17:11:15 EST
Spec Name or Url: http://apt.kde-redhat.org/apt/kde-redhat/SPECS/kimdaba-2.1-2.spec SRPM Name or Url: http://apt.kde-redhat.org/apt/kde-redhat/all/SRPMS.stable/kimdaba-2.1-2.src.rpm Description: An image database tool. KimDaBa focuses on three key points: * It must be easy to describe a number of images at a time. * It must be easy to search for images. * It must be easy to browse and View the images. Can (optionally) use kipi-plugins
Needs work: * rpmlint of kimdaba: Applications/Graphics (should be Applications/Multimedia, like digikam) * The package should contain the text of the license (COPYING file) (wiki: PackageReviewGuidelines) * Missing dependancy on update-desktop-database for %post and %postun (in package desktop-file-utils) * as for other recent packages: * remove debug_package test on make install * enable gtk-update-icon-cache in scriptlets * looks like you're getting rid of kde-redhat specific tags in CVS, please do it here too. (dist tag and BRs)
%changelog * Sat Oct 22 2005 Rex Dieter <rexdieter[AT]users.sf.net> 2.1-3 - %%doc: COPYING - Req(post,postun): update-desktop-database - gtk-update-icon-cache - remove unused crud (kde-redhat bits) - Group: Applications/Multimedia - drop %%{?debug_package} conditionals Spec Name or Url: http://apt.kde-redhat.org/apt/kde-redhat/SPECS/kimdaba-2.1-3.spec SRPM Name or Url: http://apt.kde-redhat.org/apt/kde-redhat/all/SRPMS.stable/kimdaba-2.1-3.src.rpm
Why drop Application in the desktop file category ? From http://fedoraproject.org/wiki/Extras/FedoraDesktopEntryGuidelines : « All Categories must be from the standard set (see below), with the exception that the "Application" category should be included where appropriate (ie. for everything that is supposed to be shown in the menus) for backwards compatibility even though it is not listed as a standard category. »
crap, I knew there was a reason to keep Application, even if it wasn't mentioned in the spec.
Yeah, it looks like it's needed for the "Other" submenu : /etc/xdg/menus/applications.menu, and possibly elsewhere.
%changelog * Sat Oct 22 2005 Rex Dieter <rexdieter[AT]users.sf.net> 2.1-4 - --add-category Application Spec Name or Url: http://apt.kde-redhat.org/apt/kde-redhat/SPECS/kimdaba-2.1-4.spec SRPM Name or Url: http://apt.kde-redhat.org/apt/kde-redh
SRPM Name or Url: http://apt.kde-redhat.org/apt/kde-redhat/all/SRPMS.stable/kimdaba-2.1-4.src.rpm
Review for release 4: * RPM name is OK * Source kimdaba-2.1.tar.bz2 is the same as upstream * This is the latest version * Builds fine in mock * rpmlint of kimdaba looks OK * File list of kimdaba looks OK * Works fine APPROVED
FYI, name deprecated, package renamed upstream to kphotoalbum.