Bug 1718970 - Pidone containers missing health checks
Summary: Pidone containers missing health checks
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: openstack-tripleo-heat-templates
Version: 15.0 (Stein)
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ---
: ---
Assignee: Emilien Macchi
QA Contact: Sasha Smolyak
URL:
Whiteboard:
Depends On: 1488153 1718971 1718973 1718976
Blocks: 1631705 1631707 1718962
TreeView+ depends on / blocked
 
Reported: 2019-06-10 16:18 UTC by Martin Magr
Modified: 2019-09-24 22:33 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1488153
Environment:
Last Closed: 2019-09-24 22:33:54 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Martin Magr 2019-06-10 16:18:35 UTC
+++ This bug was initially created as a clone of Bug #1488153 +++


--- Additional comment from Leonid Natapov on 2019-05-05 08:36:39 UTC ---

Back to assign.
Here is the list of containers that don't have healthcheck. Probably will be more as I will test different tripleo templates that could add additional containers that don't appear now.

cdac99e0befe  192.168.24.1:8787/rhosp15/openstack-haproxy:20190426.1                  dumb-init --singl...  3 days ago  Up 3 days ago         haproxy-bundle-podman-0
ec15b29cf0d4  192.168.24.1:8787/rhosp15/openstack-redis:20190426.1                    dumb-init --singl...  3 days ago  Up 3 days ago         redis-bundle-podman-0
3350d6f0b041  192.168.24.1:8787/rhosp15/openstack-rabbitmq:20190426.1                 dumb-init --singl...  3 days ago  Up 3 days ago         rabbitmq-bundle-podman-0
b684f5e5d809  192.168.24.1:8787/rhosp15/openstack-mariadb:20190426.1                  dumb-init -- /bin...  3 days ago  Up 3 days ago         galera-bundle-podman-0
74e83954f092  192.168.24.1:8787/rhosp15/openstack-mariadb:20190426.1                  dumb-init -- koll...  3 days ago  Up 3 days ago         clustercheck


-----------------------------------------------------

Above mentioned containers were covered with health checks in following patches:

Redis:
https://review.opendev.org/#/c/539190/
https://review.opendev.org/#/c/536405/
https://review.opendev.org/#/c/536406/

RabbitMQ:
https://github.com/openstack/tripleo-common/blob/master/healthcheck/rabbitmq
https://github.com/openstack/tripleo-common/blob/master/container-images/tripleo_kolla_template_overrides.j2#L631,L635
https://github.com/openstack/tripleo-heat-templates/blob/master/deployment/rabbitmq/rabbitmq-container-puppet.yaml#L305

Galera:
https://github.com/openstack/tripleo-common/blob/master/container-images/tripleo_kolla_template_overrides.j2#L455,L457
https://github.com/openstack/tripleo-heat-templates/blob/master/deployment/database/mysql-container-puppet.yaml#L198
https://github.com/openstack/tripleo-common/blob/master/healthcheck/mariadb

Health checks for HAProxy and cluestercheck will have to be implemented first. Please add missing health checks, enable (or refactor and enable) health checks (or eventually close this) under your consideration.

Comment 3 Andrew Beekhof 2019-07-08 21:37:30 UTC
Health checks are handled by the cluster for PIDONE containers. 
I don't expect there is any work to do here

Comment 6 Andrew Beekhof 2019-09-24 22:33:54 UTC
See previous comment


Note You need to log in before you can comment on or make changes to this bug.