Bug 1720563 - Review Request: tinygo - Go compiler for small places
Summary: Review Request: tinygo - Go compiler for small places
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-06-14 08:41 UTC by Elliott Sales de Andrade
Modified: 2019-07-24 00:58 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-07-24 00:58:13 UTC
Type: ---
Embargoed:
zebob.m: fedora-review+


Attachments (Terms of Use)

Description Elliott Sales de Andrade 2019-06-14 08:41:51 UTC
Spec URL: https://qulogic.fedorapeople.org//tinygo.spec
SRPM URL: https://qulogic.fedorapeople.org//tinygo-0.6.0-1.fc30.src.rpm

Description:

Go compiler for small places. Microcontrollers, WebAssembly, and command-line
tools. Based on LLVM.

Comment 1 Elliott Sales de Andrade 2019-06-14 08:42:53 UTC
No scratch build yet due to broken qemu, bug 1718926. This may work for you if your mirror doesn't have the broken libs.

Comment 2 Robert-André Mauchin 🐧 2019-07-10 23:48:17 UTC
 - Latest version packaged
 - License ok
 - Builds in mock
 - Conforms to Packaging Guidelines

 - These libraries should be in libdir and in a static or devel subpackage:

tinygo.x86_64: E: arch-dependent-file-in-usr-share /usr/share/tinygo/pkg/armv6m-none-eabi/compiler-rt.a
tinygo.x86_64: E: arch-dependent-file-in-usr-share /usr/share/tinygo/pkg/armv7em-none-eabi/compiler-rt.a
tinygo.x86_64: E: arch-dependent-file-in-usr-share /usr/share/tinygo/pkg/armv7m-none-eabi/compiler-rt.a

 - Use global too:

%define __brp_strip_static_archive %{nil}

Comment 3 Elliott Sales de Andrade 2019-07-11 08:51:05 UTC
Those libraries are cross-compiled compiler runtimes for the arch in the directory name. They won't be linked by anything else and are used by the cross-compiler at runtime, so I don't see any use of placing them in a separate subpackage. This is the same as, e.g., avr-gcc and its compiler runtime (libgcc.a).

I suppose these could be moved to /usr/lib instead (but not %{_libdir} as they aren't arch-specific), but then rpmlint would complain about using "lib" instead...

However, it still looks like I need to figure out some other-arch bugs:;
https://koji.fedoraproject.org/koji/taskinfo?taskID=36181932

Comment 4 Robert-André Mauchin 🐧 2019-07-12 15:37:43 UTC
Ok, packaqe approved. I'll let you see with upstream the actual supported arches.

Comment 5 Gwyn Ciesla 2019-07-12 20:32:33 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/tinygo

Comment 6 Fedora Update System 2019-07-14 09:32:52 UTC
FEDORA-2019-45dd73c3dd has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-45dd73c3dd

Comment 7 Fedora Update System 2019-07-15 01:32:19 UTC
tinygo-0.6.0-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-45dd73c3dd

Comment 8 Fedora Update System 2019-07-24 00:58:13 UTC
tinygo-0.6.0-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.