Spec Name or Url: http://apt.kde-redhat.org/apt/kde-redhat/SPECS/kxdocker-resources-0.14-1.spec SRPM Name or Url: http://apt.kde-redhat.org/apt/kde-redhat/all/SRPMS.stable/kxdocker-resources-0.14-1.src.rpm Description: Plugins, Sounds, and Themes for kxdocker
* please remove the following files or dirs: /usr/share/apps/kxdocker/themes/bar/transparent-pink/.xvpics /usr/share/apps/kxdocker/themes/pillow/label_h2o_blue_left/.DS_Store * The following file is set 0744 : /usr/share/apps/kxdocker/themes/pillow/label_h2o_blue_left/background-center.png * "make" is useless * Only kdelibs is required as a build dependency, because configure needs kde-config. However, I would put kdelibs-devel as BR. Shouldn't kde-config be in kdelibs-devel anyway ?
%changelog * Tue Nov 01 2005 Rex Dieter <rexdieter[AT]users.sf.net> 0.14-2 - remove useless dirs - fixup permissions on installed theme/resources - %%build: drop useless make Spec Name or Url: http://apt.kde-redhat.org/apt/kde-redhat/SPECS/kxdocker-resources-0.14-2.spec SRPM Name or Url: http://apt.kde-redhat.org/apt/kde-redhat/all/SRPMS.stable/kxdocker-resources-0.14-2.src.rpm IMO, it's fine that kde-config is in kdelibs and not kdelibs-devel. It's something useful at runtime.
* themes/pillow/label_h2o_blue_left/.DS_Store is still there * themes/pillow/label_h2o_blue_left/background-center.png is still set 0744 * While you're at it, you can delete "themes/pillow/label_h2o_blue_left/backgrond-right copia.png" which looks like a copy. Please report it upstream (where it should be fixed)
%changelog * Tue Nov 01 2005 Rex Dieter <rexdieter[AT]users.sf.net> 0.14-3 - prune more junk - *really* fix permissions Spec Name or Url: http://apt.kde-redhat.org/apt/kde-redhat/SPECS/kxdocker-resources-0.14-3.spec SRPM Name or Url: http://apt.kde-redhat.org/apt/kde-redhat/all/SRPMS.stable/kxdocker-resources-0.14-3.src.rpm
Review for release 3: * RPM name is OK * Source kxdocker-resources-0.14.tar.bz2 is the same as upstream * Builds fine in mock * rpmlint of kxdocker-resources looks OK * File list of kxdocker-resources looks OK * Works fine APPROVED