Bug 1724202 - Review Request: python-importlib-metadata - Read metadata from Python packages
Summary: Review Request: python-importlib-metadata - Read metadata from Python packages
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Matthias Runge
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: Trivial
Depends On: 1724196
Blocks: pre-commit 1699032 1714369
TreeView+ depends on / blocked
 
Reported: 2019-06-26 12:56 UTC by Miro Hrončok
Modified: 2019-07-26 01:00 UTC (History)
2 users (show)

Fixed In Version: python-importlib-metadata-0.18-1.fc31
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-06-27 15:56:09 UTC
Type: ---
Embargoed:
mrunge: fedora-review+


Attachments (Terms of Use)

Description Miro Hrončok 2019-06-26 12:56:50 UTC
Spec URL: https://churchyard.fedorapeople.org/SRPMS/python-importlib-metadata.spec
SRPM URL: https://churchyard.fedorapeople.org/SRPMS/python-importlib-metadata-0.18-1.fc30.src.rpm

Description:
importlib_metadata is a library which provides an API for accessing an
installed package’s metadata, such as its entry points or its top-level name.
This functionality intends to replace most uses of pkg_resources entry point
API and metadata API. Along with importlib.resources in Python 3.7 and newer
(backported as importlib_resources for older versions of Python), this can
eliminate the need to use the older and less efficient pkg_resources package.

Fedora Account System Username: churchyard

Comment 1 Matthias Runge 2019-06-27 07:19:52 UTC
I'll do a review shortly.

Comment 2 Matthias Runge 2019-06-27 08:15:46 UTC
This package depends on python-zipp.

However, the spec looks good, is readable, check is being executed during build. The package does not bundle other libraries. The license is correct andf the package follows python guidelines.

Package APPROVED

Comment 3 Gwyn Ciesla 2019-06-27 15:17:17 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-importlib-metadata

Comment 4 Miro Hrončok 2019-06-27 15:56:09 UTC
Thanks for the review!

Comment 5 Fedora Update System 2019-07-17 16:51:48 UTC
FEDORA-2019-8a4a1f7362 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-8a4a1f7362

Comment 6 Fedora Update System 2019-07-18 00:42:52 UTC
python-importlib-metadata-0.18-1.fc30, python-zipp-0.5.1-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-8a4a1f7362

Comment 7 Fedora Update System 2019-07-26 01:00:10 UTC
python-importlib-metadata-0.18-1.fc30, python-zipp-0.5.1-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.