Bug 1724415 - [Regression] Unable to capture memory metric from Azure instances
Summary: [Regression] Unable to capture memory metric from Azure instances
Keywords:
Status: CLOSED EOL
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: C&U Capacity and Utilization
Version: 5.10.6
Hardware: Unspecified
OS: Unspecified
medium
high
Target Milestone: GA
: 5.12.0
Assignee: Adam Grare
QA Contact: Nandini Chandra
Red Hat CloudForms Documentation
URL:
Whiteboard:
Depends On:
Blocks: 1767656
TreeView+ depends on / blocked
 
Reported: 2019-06-27 03:47 UTC by Nandini Chandra
Modified: 2020-03-25 18:03 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1767656 (view as bug list)
Environment:
Last Closed: 2020-03-25 18:03:41 UTC
Category: Bug
Cloudforms Team: CFME Core
Target Upstream Version:
Embargoed:
mfeifer: mirror+


Attachments (Terms of Use)

Description Nandini Chandra 2019-06-27 03:47:58 UTC
Description of problem:
------------------------
Memory metric is not being captured from Azure instances.


Version-Release number of selected component (if applicable):
-------------------------------------------------------------
5.10.6.1


How reproducible:
-----------------
Always


Steps to Reproduce:
-------------------
1.
2.
3.


Actual results:
---------------
Memory metric is not being captured from Azure instances.


Expected results:
-----------------
Memory metric should be captured from Azure instances.


Additional info:
----------------

Comment 5 Alexander Zagaynov 2019-07-30 09:36:14 UTC
PR: https://github.com/ManageIQ/manageiq-providers-azure/pull/341

Comment 6 CFME Bot 2019-08-12 16:36:21 UTC
New commit detected on ManageIQ/manageiq-providers-azure/ivanchuk:

https://github.com/ManageIQ/manageiq-providers-azure/commit/8473d9e5d7db37de50d50071c612583bbdec5947
commit 8473d9e5d7db37de50d50071c612583bbdec5947
Author:     Adam Grare <agrare>
AuthorDate: Mon Aug 12 11:59:14 2019 -0400
Commit:     Adam Grare <agrare>
CommitDate: Mon Aug 12 11:59:14 2019 -0400

    Merge pull request #341 from AlexanderZagaynov/BZ-1671580_azure_metrics

    capture memory metric

    (cherry picked from commit 3a0964bc18bd8faa4ff438cc02ed948959d88cf2)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1724415

 app/models/manageiq/providers/azure/cloud_manager/metrics_capture.rb | 173 +-
 spec/models/manageiq/providers/azure/cloud_manager/metrics_capture_spec.rb | 92 +-
 2 files changed, 178 insertions(+), 87 deletions(-)

Comment 7 Nandini Chandra 2019-08-30 23:06:15 UTC
I still don't see memory metric for Azure instances .

You could check some of my running Azure instances(nachandr-win etc.) on https://10.16.5.114. This is a 5.11.0.22 appliance.

Comment 8 Alexander Zagaynov 2019-09-03 14:00:22 UTC
Fixed in https://bugzilla.redhat.com/show_bug.cgi?id=1747858

Comment 9 CFME Bot 2019-09-03 17:46:00 UTC
New commit detected on ManageIQ/manageiq-providers-azure/ivanchuk:

https://github.com/ManageIQ/manageiq-providers-azure/commit/52e6b04be4e2da5d93e42e3418f53ec1342e9aa0
commit 52e6b04be4e2da5d93e42e3418f53ec1342e9aa0
Author:     Adam Grare <agrare>
AuthorDate: Tue Sep  3 13:31:08 2019 -0400
Commit:     Adam Grare <agrare>
CommitDate: Tue Sep  3 13:31:08 2019 -0400

    Merge pull request #347 from AlexanderZagaynov/BZ-1747858_invalid_and_syntax

    fix invalid and syntax

    (cherry picked from commit 3eca30ccf94e9ebfa8ea409b80e0629140159bfc)

    https://bugzilla.redhat.com/show_bug.cgi?id=1724415
    https://bugzilla.redhat.com/show_bug.cgi?id=1747858

 app/models/manageiq/providers/azure/cloud_manager/metrics_capture.rb | 10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)

Comment 14 dmetzger 2019-09-10 12:47:33 UTC
Moving to 5.11.1 per CF Program Leads discussion.

Comment 15 Alexander Zagaynov 2019-09-10 13:17:46 UTC
So, the question now is how this metric should be named.

I see in the charts settings, that it is some "derived_..." columns: https://github.com/ManageIQ/manageiq/blob/2d001e04b8394c4da18ccbdbc4148bc9d5206a16/product/charts/miq_reports/vim_perf_realtime.yaml#L30

In the old code it is named "mem_usage_absolute_average": https://github.com/ManageIQ/manageiq-providers-azure/blob/921d5e37cbc997c4d5a5014297675474046f2c18/app/models/manageiq/providers/azure/cloud_manager/metrics_capture.rb#L35

In the current code it is named "mem_usage_rate_average": https://github.com/ManageIQ/manageiq-providers-azure/blob/8ce95c67f66d586bead1c07a3981ac23c152d4e6/app/models/manageiq/providers/azure/cloud_manager/metrics_capture.rb#L23

I've prepared a PR to rename it back, but still unsure will it help - need to research with UI
https://github.com/ManageIQ/manageiq-providers-azure/pull/351

Comment 17 Alexander Zagaynov 2019-09-10 14:44:55 UTC
PR merged

Comment 18 Nandini Chandra 2019-09-10 16:21:36 UTC
Tested the patched appliance.

Verified that CFME is collecting memory metric for both Linux and Windows instances.

The memory Utilization graphs also look good.


Note You need to log in before you can comment on or make changes to this bug.