Bug 1727137 - dnf download ignores destdir argument for some packages
Summary: dnf download ignores destdir argument for some packages
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: dnf-plugins-core
Version: 30
Hardware: Unspecified
OS: Unspecified
high
medium
Target Milestone: ---
Assignee: amatej
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1727853
TreeView+ depends on / blocked
 
Reported: 2019-07-04 15:15 UTC by Tim Smith
Modified: 2020-05-04 06:12 UTC (History)
8 users (show)

Fixed In Version: dnf-4.2.15-3.fc30
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1727853 (view as bug list)
Environment:
Last Closed: 2020-05-04 06:12:27 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Tim Smith 2019-07-04 15:15:16 UTC
Description of problem:

dnf download ignores destdir argument when fetching remote packages through a local repository

Version-Release number of selected component (if applicable):
dnf-plugins-core-4.0.7-1.fc30

How reproducible:
Always

Steps to Reproduce:
1. Create a local repository using createrepo_c at /some/path

2. Merge a remote repository into it with mergerepo_c. Now you have a mix of some packages with just <location href="x86_64/foo-1.0.0-1.x86_64.rpm"> and some with <location xml:base="http://somewhere.else/" href="bar-2.0.0-2.x86_64.rpm">

3. dnf download --repofrompath="fred,file:///some/path" --repo fred --destdir /tmp foo bar


Actual results:

/some/path/x86_64/foo-1.0.0-1.x86_64.rpm is correctly copied to /tmp/foo-1.0.0-1.x86_64.rpm

BUT

http://somewhere.else/bar-2.0.0-2.x86_64.rpm is downloaded to /some/path/bar-2.0.0-2.x86_64.rpm

Whut?


Expected results:

Both foo-1.0.0-1.x86_64.rpm and bar-2.0.0-2.x86_64.rpm should be copied to /tmp

Additional info:

Comment 1 amatej 2019-08-21 08:53:17 UTC
I created a patch for DNF that should fix this: https://github.com/rpm-software-management/dnf/pull/1464

And here are tests for this: https://github.com/rpm-software-management/ci-dnf-stack/pull/589

Comment 2 Fedora Update System 2019-11-11 09:43:22 UTC
FEDORA-2019-7cafbe66ba has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-7cafbe66ba

Comment 3 Fedora Update System 2019-11-11 09:43:54 UTC
FEDORA-2019-94393775ec has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-94393775ec

Comment 4 Fedora Update System 2019-11-12 03:07:44 UTC
dnf-4.2.15-1.fc30, dnf-plugins-core-4.0.11-1.fc30, dnf-plugins-extras-4.0.8-1.fc30, libdnf-0.37.2-2.fc30, librepo-1.11.0-1.fc30, microdnf-3.0.2-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-7cafbe66ba

Comment 5 Fedora Update System 2019-11-13 04:56:12 UTC
dnf-4.2.15-1.fc31, dnf-plugins-core-4.0.11-1.fc31, dnf-plugins-extras-4.0.8-1.fc31, libdnf-0.37.2-2.fc31, librepo-1.11.0-1.fc31, microdnf-3.0.2-1.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-94393775ec

Comment 6 Fedora Update System 2019-11-14 06:47:01 UTC
FEDORA-2019-7cafbe66ba has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-7cafbe66ba

Comment 7 Fedora Update System 2019-11-14 06:50:48 UTC
FEDORA-2019-94393775ec has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-94393775ec

Comment 8 Fedora Update System 2019-11-15 03:45:09 UTC
dnf-4.2.15-3.fc30, dnf-plugins-core-4.0.11-1.fc30, dnf-plugins-extras-4.0.8-1.fc30, libdnf-0.37.2-2.fc30, librepo-1.11.0-1.fc30, microdnf-3.0.2-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-7cafbe66ba

Comment 9 Fedora Update System 2019-11-15 04:38:41 UTC
dnf-4.2.15-2.fc31, dnf-plugins-core-4.0.11-1.fc31, dnf-plugins-extras-4.0.8-1.fc31, libdnf-0.37.2-2.fc31, librepo-1.11.0-1.fc31, microdnf-3.0.2-1.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-94393775ec

Comment 10 Fedora Update System 2019-11-19 01:35:13 UTC
dnf-4.2.15-2.fc31, dnf-plugins-core-4.0.11-1.fc31, dnf-plugins-extras-4.0.8-1.fc31, libdnf-0.37.2-2.fc31, librepo-1.11.0-1.fc31, microdnf-3.0.2-1.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2019-12-02 19:10:34 UTC
dnf-4.2.15-3.fc30, dnf-plugins-core-4.0.11-1.fc30, dnf-plugins-extras-4.0.8-1.fc30, libdnf-0.37.2-2.fc30, librepo-1.11.0-1.fc30, microdnf-3.0.2-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.

Comment 12 Ben Cotton 2020-04-30 20:26:41 UTC
This message is a reminder that Fedora 30 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 30 on 2020-05-26.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '30'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 30 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.


Note You need to log in before you can comment on or make changes to this bug.