Bug 1731720 - perl-File-LibMagic depends on files/directories from non-standard locations
Summary: perl-File-LibMagic depends on files/directories from non-standard locations
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: perl-File-LibMagic
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Paul Howarth
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1731683
TreeView+ depends on / blocked
 
Reported: 2019-07-21 11:11 UTC by Igor Raits
Modified: 2019-07-22 10:54 UTC (History)
3 users (show)

Fixed In Version: perl-File-LibMagic-1.16-7.fc31
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-07-22 10:54:50 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Igor Raits 2019-07-21 11:11:50 UTC
Hello,

Fedora Packaging Guidelines allow dependencies only on files/directories from /usr/bin, /usr/sbin and /etc directories[0].
Your package depends on files/directories outside of those. See below for more information about package/dependencies.

---
perl-File-LibMagic-1.16-6.fc31.src:
  - /usr/include/magic.h
---

Please correct those or provide reason why is it correct.
It is very important to not download huge filelists.xml just because few packages in distribution depend on non-standard paths.

Thanks for cooperation!


[0] https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_and_directory_dependencies

Comment 1 Paul Howarth 2019-07-22 10:54:50 UTC
Well that one's been there since before I took over the package. I could have sworn there was language in the guidelines about file/dir Requires being deprecated but not necessarily BuildRequires like this one, but I can't see anything about that even in old guidelines. Typically I'd use a file build dependency like this when the file concerned had moved between packages, thus avoiding a conditional.

Anyway, none of that matters in this case. Fixed in Rawhide:
https://src.fedoraproject.org/rpms/perl-File-LibMagic/c/4e812a8b


Note You need to log in before you can comment on or make changes to this bug.