Created attachment 1593389 [details] Error after clicking on Back button Description of problem: Cannot go back after clicking on Back button, while displaying Right-Size Recommendations of a VM, chosen from a nested list of a Datastore. Version-Release number of selected component (if applicable): 5.10.7, 5.11 How reproducible: 100% Steps to Reproduce: 1. Go to Compute > Infrastructure > Datastores 2. Display some datastore's textual summary (click on some datastore) 3. Click on Managed VMs from Relationships table 4. Choose some VM (check the checkbox) 5. Configuration > Right-Size Recommendations 6. Click on Back button Actual results: Cannot go back to the nested list of VMs, error: [----] F, [2019-07-24T15:18:26.675725 #16801:2abbb229339c] FATAL -- : Error caught: [ActiveRecord::RecordNotFound] Can't access records without an id /home/hstastna/manageiq/manageiq-ui-classic/app/controllers/mixins/checked_id_mixin.rb:58:in `find_records_with_rbac' /home/hstastna/manageiq/manageiq-ui-classic/app/controllers/mixins/checked_id_mixin.rb:44:in `find_record_with_rbac' /home/hstastna/manageiq/manageiq-ui-classic/app/controllers/vm_common.rb:512:in `right_size' Expected results: Displaying the list of VMs again, the same as after step 3, no error present. Additional info: Clicking on Back button of a browser may 'fix' the problem. This bug is unrelated to https://bugzilla.redhat.com/show_bug.cgi?id=1729953 however it may look similar. This bug requires a different fix for sure.
https://github.com/ManageIQ/manageiq-ui-classic/pull/5878
New commit detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/3389bddbbf92111c8084818ff5c1a2ac66d697c1 commit 3389bddbbf92111c8084818ff5c1a2ac66d697c1 Author: Harpreet Kataria <hkataria> AuthorDate: Thu Jul 25 14:01:20 2019 -0400 Commit: Harpreet Kataria <hkataria> CommitDate: Thu Jul 25 14:01:20 2019 -0400 Fixed issues with 'Back' button on right size screen Multiple issues fixed with back button on non-explorer version of VM Right Size recommendations screen - fixed a typo it should be `@record.id` - fixed call to javascript_prologue, method does not expect argument - added code to redirect back to previous screen when back button is pressed Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1733207 app/controllers/vm_common.rb | 3 +- app/views/vm_common/_right_size.html.haml | 2 +- spec/controllers/vm_controller_spec.rb | 22 + 3 files changed, 25 insertions(+), 2 deletions(-)
New commit detected on ManageIQ/manageiq-ui-classic/ivanchuk: https://github.com/ManageIQ/manageiq-ui-classic/commit/110c395d10f97d045341b6494d616b327663cf74 commit 110c395d10f97d045341b6494d616b327663cf74 Author: Milan Zázrivec <mzazrivec> AuthorDate: Tue Jul 30 09:06:25 2019 -0400 Commit: Milan Zázrivec <mzazrivec> CommitDate: Tue Jul 30 09:06:25 2019 -0400 Merge pull request #5878 from h-kataria/vm_right_size_back_button_fix Fixed issues with 'Back' button on right size screen (cherry picked from commit a459a4823a30b138f44a412b8c10a1f969b1b19a) https://bugzilla.redhat.com/show_bug.cgi?id=1733207 app/controllers/vm_common.rb | 3 +- app/views/vm_common/_right_size.html.haml | 2 +- spec/controllers/vm_controller_spec.rb | 22 + 3 files changed, 25 insertions(+), 2 deletions(-)
Hi Patrthvi, I was able to reproduce the bug in both of your appliances easily.
Hey Hilda, can you create a video attachment, please? I followed the steps you mentioned in the description but wasn't able to reproduce them, a video on reproducing this bug would help.
Hi, this is how I was able to reproduce on your appliance for 5.11.0.17 version: http://g.recordit.co/9V6OLL2kTf.gif
FIXED. Verified on 5.11.0.19.20190813184334_ed72c9f. Thanks for the help Hilda, I was able to reproduce bug and verify it on the fixed version.