Bug 1738019 - Update LV cache related variables in generated vars file
Summary: Update LV cache related variables in generated vars file
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: cockpit-ovirt
Classification: oVirt
Component: gluster-ansible
Version: 0.13.1
Hardware: x86_64
OS: Linux
unspecified
high
Target Milestone: ovirt-4.3.6
: 0.13.6
Assignee: Gobinda Das
QA Contact: SATHEESARAN
URL:
Whiteboard:
Depends On:
Blocks: 1734717
TreeView+ depends on / blocked
 
Reported: 2019-08-06 12:32 UTC by Gobinda Das
Modified: 2019-09-26 19:43 UTC (History)
5 users (show)

Fixed In Version: cockpit-ovirt-0.13.6
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1734717
Environment:
Last Closed: 2019-09-26 19:43:19 UTC
oVirt Team: Gluster
Embargoed:
sbonazzo: ovirt-4.3?


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 102459 0 master MERGED Allow cachemetalvsize and cachemetalvname to auto calculate by LVM 2019-08-09 07:29:11 UTC
oVirt gerrit 102548 0 ovirt-4.3 MERGED Allow cachemetalvsize and cachemetalvname to auto calculate by LVM 2019-08-12 09:38:19 UTC

Description Gobinda Das 2019-08-06 12:32:10 UTC
Description of problem:
-------------------------
Few of the params in lvcache section are not required and will be auto-computed

Following variables are not required:
          cachethinpoolname: gluster_thinpool_gluster_vg_sdd
          cachemetalvsize: 2G


Version-Release number of selected component (if applicable):
---------------------------------------------------------------
RHHI-V 1.6
cockpit-ovirt-dashboard-0.13.5


How reproducible:
-----------------
NA


Steps to Reproduce:
--------------------
1. Enable lv cache 

Actual results:
---------------
1. cache lv meta size is computed
2. lv cache meta name is computed

Expected results:
------------------
When the above said options are not mentioned, lv cache meta is automatically computed by LV which is more safer


Additional info:

Comment 2 SATHEESARAN 2019-08-06 15:17:07 UTC
(In reply to Gobinda Das from comment #0)
> Description of problem:
> -------------------------
> Few of the params in lvcache section are not required and will be
> auto-computed
> 
> Following variables are not required:
>           cachethinpoolname: gluster_thinpool_gluster_vg_sdd
>           cachemetalvsize: 2G
Incorrect description.
It was not the **cachethinpoolname** but the **cachemetalvname**

Comment 3 SATHEESARAN 2019-09-03 05:16:48 UTC
Tested with cockpit-ovirt-dashboard-0.13.6

All the optional params for lvcache are removed, leaving LVM
to compute it by default.

LV cache related params in the generated vars file looks like:

<snip>
      gluster_infra_cache_vars:
        - vgname: gluster_vg_sdb
          cachedisk: '/dev/sdb,/dev/sdc'
          cachelvname: cachelv_gluster_thinpool_gluster_vg_sdb
          cachethinpoolname: gluster_thinpool_gluster_vg_sdb
          cachelvsize: 225G
          cachemode: writeback
</snip>

Comment 4 Sandro Bonazzola 2019-09-26 19:43:19 UTC
This bugzilla is included in oVirt 4.3.6 release, published on September 26th 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.3.6 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.