Red Hat Bugzilla – Bug 174016
Temporary filename buffer one byte too short
Last modified: 2007-11-30 17:07:21 EST
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.12) Gecko/20050915 Firefox/1.0.7
Description of problem:
There is an off-by-one in the malloc for the temporary filename in MakeTempFileFrom(). No space is reserved for the terminating zero. This causes segfaults for some lengths of directory names.
In the unix2dos package this is already fixed.
Version-Release number of selected component (if applicable):
Steps to Reproduce:
1.mkdir -p src/utils/misc/doschk/
3.dos2unix -c iso -o ./src/utils/misc/doschk/README
Actual Results: dos2unix: converting file ./src/utils/misc/doschk/README to UNIX format ...
dos2unix: problems renaming './src/utils/misc/doschk/d2utmp2j4mDb' to './src/utils/misc/doschk/README'
output file remains in './src/utils/misc/doschk/d2utmp2j4mDb'
dos2unix: problems converting file ./src/utils/misc/doschk/README
Note that the output filename ends in junk (view the output with less or similar).
Expected Results: dos2unix: converting file ./src/utils/misc/doschk/README to UNIX format ...
Add 1 to the fname_len calculation in MakeTempFileFrom in dos2unix.c.
*** Bug 178772 has been marked as a duplicate of this bug. ***
*** Bug 178941 has been marked as a duplicate of this bug. ***
*** Bug 185298 has been marked as a duplicate of this bug. ***
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on the solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.
*** Bug 196703 has been marked as a duplicate of this bug. ***