Bug 1740899 - Required dialog option with Integer value type will not validate
Summary: Required dialog option with Integer value type will not validate
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.10.8
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: GA
: 5.11.0
Assignee: Martin Hradil
QA Contact: Niyaz Akhtar Ansari
Red Hat CloudForms Documentation
URL:
Whiteboard:
: 1742196 1743849 (view as bug list)
Depends On:
Blocks: 1748455
TreeView+ depends on / blocked
 
Reported: 2019-08-13 19:59 UTC by Jarryd Novotni
Modified: 2020-01-09 15:21 UTC (History)
17 users (show)

Fixed In Version: 5.11.0.23
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1748455 (view as bug list)
Environment:
Last Closed: 2019-12-13 14:57:22 UTC
Category: Bug
Cloudforms Team: CFME Core
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
CF says field is required even when a value is selected (4.77 KB, image/png)
2019-08-13 19:59 UTC, Jarryd Novotni
no flags Details

Description Jarryd Novotni 2019-08-13 19:59:35 UTC
Created attachment 1603542 [details]
CF says field is required even when a value is selected

Description of problem:
When you create a required field with a value type of Integer, the dialog will continue to say that the field is required even after selecting a value. 

Version-Release number of selected component (if applicable):
5.11.0.18

How reproducible:
Always

Steps to Reproduce:
1. Create a dialog dropdown that is required with a value type of integer
2. Order a catalog item that uses that dialog
3. Make a selection for the dropdown

Actual results:
CF will say that the option is required, even when you've chosen a value

Expected results:
The field should validate successfully

Additional info:

Comment 2 Harpreet Kataria 2019-08-16 16:16:02 UTC
*** Bug 1742196 has been marked as a duplicate of this bug. ***

Comment 4 Harpreet Kataria 2019-08-21 19:01:23 UTC
*** Bug 1743849 has been marked as a duplicate of this bug. ***

Comment 8 Shveta 2019-08-28 18:02:59 UTC
Niyaz , 

Can you please attach the dialog and domain required for this BZ .
adding it to customer BZ tracking sheet .

Thanks, 
Shveta

Comment 10 CFME Bot 2019-08-28 20:27:34 UTC
New commit detected on ManageIQ/ui-components/master:

https://github.com/ManageIQ/ui-components/commit/79770735b5e57fe65edec8b3fc39eebb68be4b0d
commit 79770735b5e57fe65edec8b3fc39eebb68be4b0d
Author:     Erik Clarizio <eclarizio>
AuthorDate: Wed Aug 28 14:34:57 2019 -0400
Commit:     Erik Clarizio <eclarizio>
CommitDate: Wed Aug 28 14:34:57 2019 -0400

    Use _.isNaN for integer required validation instead of _.isEmpty

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1740899

 src/dialog-user/services/dialogData.spec.ts | 94 +-
 src/dialog-user/services/dialogData.ts | 10 +-
 2 files changed, 84 insertions(+), 20 deletions(-)

Comment 16 CFME Bot 2019-09-03 17:46:59 UTC
New commit detected on ManageIQ/ui-components/ivanchuk:

https://github.com/ManageIQ/ui-components/commit/62638231238ba9934ecc3fb792481a65abb7b11d
commit 62638231238ba9934ecc3fb792481a65abb7b11d
Author:     Harpreet Kataria <hkataria>
AuthorDate: Wed Aug 28 16:23:54 2019 -0400
Commit:     Harpreet Kataria <hkataria>
CommitDate: Wed Aug 28 16:23:54 2019 -0400

    Merge pull request #410 from eclarizio/BZ1740899-fix-required-integer-value

    Use _.isNaN for integer required validation instead of _.isEmpty

    (cherry picked from commit 485efda2323d23b349794ae1ad550c4d6cb2c58e)

    https://bugzilla.redhat.com/show_bug.cgi?id=1740899

 src/dialog-user/services/dialogData.spec.ts | 94 +-
 src/dialog-user/services/dialogData.ts | 10 +-
 2 files changed, 84 insertions(+), 20 deletions(-)

Comment 18 Niyaz Akhtar Ansari 2019-09-06 11:40:27 UTC
Verified in Version 5.11.0.23.20190904213640_d113674

Comment 19 CFME Bot 2020-01-09 15:21:03 UTC
New commit detected on ManageIQ/manageiq-ui-service/ivanchuk:

https://github.com/ManageIQ/manageiq-ui-service/commit/3b444d761df53a3ed08a8b43c82d970ebb08795f
commit 3b444d761df53a3ed08a8b43c82d970ebb08795f
Author:     Martin Hradil <mhradil>
AuthorDate: Thu Jan  9 09:59:59 2020 -0500
Commit:     Martin Hradil <mhradil>
CommitDate: Thu Jan  9 09:59:59 2020 -0500

    Update ui-components to 1.2.16 for ivanchuk

    v1.2.16
        ManageIQ/ui-components#428
        ManageIQ/ui-components#430

        https://bugzilla.redhat.com/show_bug.cgi?id=1773627
        https://bugzilla.redhat.com/show_bug.cgi?id=1783375

    v1.2.15
        ManageIQ/ui-components#412
        ManageIQ/ui-components#414
        ManageIQ/ui-components#422

        https://bugzilla.redhat.com/show_bug.cgi?id=1767836
        https://bugzilla.redhat.com/show_bug.cgi?id=1768456

    v1.2.14
        ManageIQ/ui-components#410

        https://bugzilla.redhat.com/show_bug.cgi?id=1740899

 package.json | 2 +-
 yarn.lock | 8 +-
 2 files changed, 5 insertions(+), 5 deletions(-)


Note You need to log in before you can comment on or make changes to this bug.