Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://copr.fedorainfracloud.org/coprs/jcpunk/ocsinventory-review/build/1008890/ SRPM URL: https://copr.fedorainfracloud.org/coprs/jcpunk/ocsinventory-review/build/1008890/ Description: This is a simple tool for reading monitor EDIDs Fedora Account System Username:jcpunk
>Group: System Environment/Base Not used in Fedora. ># run monitor-edid-makesource.sh to create >Source0: %{name}-%{version}.tar.bz2 >Source1: %{name}-makesource.sh You can use a one of these URLs to get a snapshot as an archive: https://gitweb.mageia.org/software/monitor-edid/snapshot/refs/tags/{GIT_TAG}.tar.gz https://gitweb.mageia.org/software/monitor-edid/snapshot/{GIT_COMMIT}.tar.gz >%build >%make_build CFLAGS="%{optflags}" Use %set_build_flags and a normal make call here. >%doc README NEWS COPYING ChangeLog COPYING should be marked as %license.
I believe I've addressed the comments in the new build: https://copr.fedorainfracloud.org/coprs/jcpunk/ocsinventory-review/build/1008995/
- %{__make} → make - Use a better name for your archive: Source0: https://gitweb.mageia.org/software/monitor-edid/snapshot/refs/tags/v%{version}.tar.gz#/%{name}-%{version}.tar.gz - Remove trailing spaces in description - Not needed: %defattr(-,root,root,-) - Please add a comment or a upstream bug report explaining why the patches are needed - Don't mix tabs and spaces: monitor-edid.src:12: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 12) Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GPL (v3 or later)". 77 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/monitor-edid/review-monitor- edid/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [!]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 51200 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in monitor- edid [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: monitor-edid-3.2-1.fc32.x86_64.rpm monitor-edid-debuginfo-3.2-1.fc32.x86_64.rpm monitor-edid-debugsource-3.2-1.fc32.x86_64.rpm monitor-edid-3.2-1.fc32.src.rpm monitor-edid.x86_64: W: no-manual-page-for-binary monitor-parse-edid monitor-edid.x86_64: W: no-manual-page-for-binary monitor-edid monitor-edid.x86_64: W: no-manual-page-for-binary monitor-get-edid monitor-edid.x86_64: W: no-manual-page-for-binary monitor-get-edid-using-vbe monitor-edid.src:61: W: macro-in-comment %{__make} monitor-edid.src:12: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 12) 4 packages and 0 specfiles checked; 0 errors, 6 warnings.
I've loaded a new build addressing the comments listed here: https://copr.fedorainfracloud.org/coprs/jcpunk/ocsinventory-review/package/monitor-edid/ I'm working with upstream to determine what suitable manpages for the binaries would look like.
Still has issues with mixed tabs and spaces: monitor-edid.src:10: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 10) Replace all the tabs with spaces. Package approved, but please fix the aforementioned issue before import.
I'm not showing membership to https://src.fedoraproject.org/rpms/monitor-edid/ I'm getting : $ git push X11 forwarding request failed on channel 0 Counting objects: 8, done. Delta compression using up to 8 threads. Compressing objects: 100% (6/6), done. Writing objects: 100% (7/7), 3.71 KiB | 0 bytes/s, done. Total 7 (delta 0), reused 0 (delta 0) remote: Branch refs/heads/master is unsupported remote: Denied push for ref 'refs/heads/master' for user 'jcpunk' remote: All changes have been rejected To ssh://jcpunk.org/rpms/monitor-edid ! [remote rejected] master -> master (pre-receive hook declined) error: failed to push some refs to 'ssh://jcpunk.org/rpms/monitor-edid'
https://bodhi.fedoraproject.org/updates/FEDORA-2019-8a397aba13 I'd say this can be closed out now.