Bug 1744514 - [RFE] automate method to delete a tag from a category
Summary: [RFE] automate method to delete a tag from a category
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: Automate
Version: 5.10.9
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: GA
: 5.12.0
Assignee: Jay Zeng
QA Contact: Ganesh Hubale
Red Hat CloudForms Documentation
URL:
Whiteboard:
Depends On:
Blocks: 1767901
TreeView+ depends on / blocked
 
Reported: 2019-08-22 10:15 UTC by Gellert Kis
Modified: 2023-03-24 15:18 UTC (History)
10 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1767901 (view as bug list)
Environment:
Last Closed: 2020-03-20 15:42:33 UTC
Category: Feature
Cloudforms Team: CFME Core
Target Upstream Version:
Embargoed:
mfeifer: mirror+


Attachments (Terms of Use)

Comment 4 Tina Fitzgerald 2019-08-23 10:32:31 UTC
Hi Loic,

I'm concerned about exposing tag_delete to Automate. 
Deleting tags could cause issues for objects already using that tag value.

Thoughts?

Thanks,
Tina

Comment 5 Loic Avenel 2019-08-23 11:03:31 UTC
(In reply to Tina Fitzgerald from comment #4)
> Hi Loic,
> 
> I'm concerned about exposing tag_delete to Automate. 
> Deleting tags could cause issues for objects already using that tag value.
> 
> Thoughts?
> 
> Thanks,
> Tina

Agreed, we will then report an error is Tags are still in use...

Comment 6 Greg McCullough 2019-09-03 17:13:35 UTC
Jay, the existing logic to create tags is here: https://github.com/ManageIQ/manageiq-automation_engine/blob/master/lib/miq_automation_engine/engine/miq_ae_method_service/miq_ae_service_methods.rb#L90

I suggest we also offer a `category_delete` to match the create and follow the same behavior that you can only delete the category if it no longer contains tags.

Comment 7 dmetzger 2019-09-23 18:54:35 UTC
What is the PR(s) associated with this BZ?

Comment 8 Jay Zeng 2019-09-23 19:05:13 UTC
(In reply to dmetzger from comment #7)
> What is the PR(s) associated with this BZ?

Please check the following two PRs:
https://github.com/ManageIQ/manageiq-automation_engine/pull/358
https://github.com/ManageIQ/manageiq-automation_engine/pull/363


Note You need to log in before you can comment on or make changes to this bug.