Red Hat Bugzilla – Bug 176855
Review Request: python-cpio: A Python module for accessing cpio archives
Last modified: 2010-02-22 15:06:04 EST
Spec Name or Url: http://fedora.ivazquez.net/files/extras/python-cpio.spec
SRPM Name or Url: http://fedora.ivazquez.net/files/extras/python-cpio-0.1-1.src.rpm
Description: This is a Python module for accessing cpio archives.
This should be a quick review for anyone that just wants to put one under their belt. Also, I'd appreciate it if a better Summary and/or Description was suggested so I could pilfer it.
Sorry for a bit off-topic comment but how *.pyo files should be handled? In
/usr/share/fedora/spectemplate-python.spec from fedora-rpmdevtools there is such
# mark *.pyo as %ghost (do not include in package).
but in your spec file and in some Extras' packages these files are provided in
final RPMs. I'm asking because this problem concerns my package, too ( bug
I personally don't consider it a big deal myself. At the moment I have about
17MB of .pyo files, which is a drop in the bucket compared to things like the
kernel or X, or even Python itself.
(In reply to comment #1)
> Sorry for a bit off-topic comment but how *.pyo files should be handled? In
> /usr/share/fedora/spectemplate-python.spec from fedora-rpmdevtools there is such
> a comment:
> # mark *.pyo as %ghost (do not include in package).
> but in your spec file and in some Extras' packages these files are provided in
> final RPMs. I'm asking because this problem concerns my package, too ( bug
> #176653 ).
Include the *.pyo files in the files list, optionally with the %ghost attribute.
Without the %ghost attribute, the files will be included as normal.
With the %ghost attribute, the files won't be included in the RPM but will be
removed if they exist when then package is removed (and they might exist if root
runs the application and the .pyo files get written at that time).
Either way, the package cleans up after itself when it's removed. Your choice
which way to go.
-RPM name is OK
-Source python-cpio-0.1.tar.bz2 is the same as upstream (which I see is you)
-rpmlint of python-cpio looks fine, no output
-File list of python-cpio looks OK
-Builds fine in mock and FC-4
- Encoding should be UTF-8
Hi Mike -- was Comment #4 a full review with just the UTF-8 change needed before
Ignacio, are you going to produce an update or are you busy?
(In reply to comment #4)
> - Encoding should be UTF-8
I don't understand what you mean by this. Which file isn't in UTF-8?
I thought the spec file wasn't but it looks ok under closer inspection. The
file command was confused:
python-cpio.spec: lex description text
Its be'cause of the first two lines in the spec file. Remove them and file is
python-cpio.spec: ASCII text
Needless to say, false positive.
Nothing has changed from comment #4.
This is actually a bug in my fedora-qa script, which I have just fixed.
Built under FC-4 and devel.
I have sent a message to jamatos on 8 Feb 2010 about branching this package for EPEL with no response. Requesting an EPEL-5 branch that I will maintain.
Package Change Request
Package Name: python-cpio
New Branches: EL-5