Bug 1768662 - kubevirt-web-ui-components dependency loads on console load, significantly increasing the size of console JS
Summary: kubevirt-web-ui-components dependency loads on console load, significantly in...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Console Kubevirt Plugin
Version: 4.3.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ---
: 4.3.0
Assignee: Marek Libra
QA Contact: Nelly Credi
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-11-04 22:12 UTC by Samuel Padgett
Modified: 2020-01-23 11:11 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-01-23 11:10:52 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
yarn run analyze report (1.90 MB, text/html)
2019-11-04 22:12 UTC, Samuel Padgett
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Github openshift console pull 3335 0 'None' 'closed' 'Bug 1768662: kubevirt-web-ui in vendor main and getVMTemplate fix' 2019-11-25 03:21:47 UTC
Red Hat Product Errata RHBA-2020:0062 0 None None None 2020-01-23 11:11:05 UTC

Description Samuel Padgett 2019-11-04 22:12:41 UTC
Created attachment 1632774 [details]
yarn run analyze report

This dependency should only load when the user visits a kubevirt page. kubevirt-web-ui-components increases the console main vendor bundle size from 1.68 MB to 2.94 MB. As a side effect, it broke console loading on the Edge browser (bug 1767853).

It appears to have been introduced in https://github.com/openshift/console/pull/2392

This is only an issue in nightly 4.3 builds, not in 4.2.

Comment 1 Samuel Padgett 2019-11-08 17:52:31 UTC
This is the line that introduced the problem:

https://github.com/openshift/console/pull/2392/files#diff-80f3aa1672977fbd4c80165ab2066031R2

packages/kubevirt-plugin/src/selectors/vm-template/selectors.ts
2:import { getVmTemplate } from 'kubevirt-web-ui-components';

Comment 3 Rastislav Wagner 2019-11-27 11:51:15 UTC
kubevirt-web-ui-components are not in main vendor bundle anymore - checked with yarn run analyze against release-4.3 branch

Comment 5 errata-xmlrpc 2020-01-23 11:10:52 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:0062


Note You need to log in before you can comment on or make changes to this bug.