Description of problem:

engine-cleanup was executed to remove only "WebSocket proxy".

===
          Do you want to remove all components? (Yes, No) [Yes]: No
          Do you want to remove Core files? (Yes, No) [No]: 
          Do you want to remove PKI keys? (Yes, No) [No]: 
          Do you want to remove ovirt-provider-ovn configuration files? (Yes, No) [No]: 
          Do you want to remove Apache SSL configuration? (Yes, No) [No]: 
          Do you want to remove PKI configuration? (Yes, No) [No]: 
          Do you want to remove VMConsole Helper PKI keys? (Yes, No) [No]: 
          Do you want to remove Versionlock Plugin Configuration? (Yes, No) [No]: 
          Do you want to remove YUM version locking configuration? (Yes, No) [No]: 
          Do you want to remove DWH files? (Yes, No) [No]: 
          Do you want to remove VMConsole PKI Proxy keys? (Yes, No) [No]: 
          Do you want to remove the engine? (Yes, No) [No]: 
          Do you want to remove DWH DB content? All data will be lost (Yes, No) [No]: 
          Do you want to remove the Image I/O Proxy? (Yes, No) [No]: 
          Do you want to remove the WebSocket proxy? (Yes, No) [No]: Yes
====

Answer "No" was provided for the removal of core, PKI,OVN, etc. However, these options were ignored by the engine-cleanup and it removed all the files listed in uninstall.conf.

====
2019-11-18 13:25:21,839-0500 DEBUG otopi.context context.dumpEnvironment:741 ENV OVESETUP_REMOVE/filesToRemove=set:'set(['/etc/pki/ovirt-engine/keys/reports.key.nopass', '/etc/ovirt-provider-ovn/conf.d/10-setup-ovirt-provider-ovn.conf', '/etc/httpd/conf.d/ovirt-engine-root-redirect.conf', '/etc/pki/ovirt-engine/cacert.conf', '/etc/httpd/conf.d/z-ovirt-engine-proxy.conf',...................................................................................
 '/etc/ovirt-engine/ovirt-vmconsole-proxy-helper.conf.d/10-setup.conf', '/etc/pki/ovirt-engine/keys/vmconsole-proxy-helper.p12', '/etc/pki/ovirt-vmconsole/proxy-ssh_user_rsa', '/etc/pki/ovirt-engine/certs/ovirt-provider-ovn.cer'])'

          --== SUMMARY ==--
         
          Engine setup successfully cleaned up
          Core files files not removed
          PKI keys files not removed
          ovirt-provider-ovn configuration files files not removed
          Apache SSL configuration files not removed
          PKI configuration files not removed
          VMConsole Helper PKI keys files not removed
          Versionlock Plugin Configuration files not removed
          YUM version locking configuration files not removed
          DWH files files not removed
          VMConsole PKI Proxy keys files not removed
         
          --== END OF SUMMARY ==--

# ls -l /etc/pki/ovirt-engine/cacert.conf
ls: cannot access /etc/pki/ovirt-engine/cacert.conf: No such file or directory
=======

Although the engine-cleanup asks the user the options, it never uses that for selecting the files to remove and takes everything from uninstall.conf.


osetupcons.RemoveEnv.REMOVE_GROUPS is not considered while setting "self._toremove".

=======
/usr/share/ovirt-engine/setup/plugins/ovirt-engine-remove/base/files/simple.py

204                 if group not in self.environment[
205                     osetupcons.RemoveEnv.REMOVE_SPEC_OPTION_GROUP_LIST
206                 ]:
207                     add_group = dialog.queryBoolean(
208                         dialog=self.dialog,
209                         name='OVESETUP_REMOVE_GROUP/' + group,
210                         note=_(
211                             'Do you want to remove {description}? '
212                             '(@VALUES@) [@DEFAULT@]: '
213                         ).format(
214                             description=description,
215                         ),
216                         prompt=True,
217                         true=_('Yes'),
218                         false=_('No'),
219                         default=False,
220                     )
221             if add_group:
222                 self.environment[
223                     osetupcons.RemoveEnv.
224                     REMOVE_GROUPS
225                 ] += ',' + group
226 
227         self._toremove = set([
228             name
229             for name, info in self.environment[
230                 osetupcons.CoreEnv.UNINSTALL_FILES_INFO
231             ].items()
232             if 'unremovable' not in info['groups']
233         ])
=======

It looks like the change https://gerrit.ovirt.org/#/c/95492/ caused this bug.


Version-Release number of selected component (if applicable):

ovirt-engine-setup-base-4.3.6.7-0.1.el7.noarch

How reproducible:

100%

Steps to Reproduce:

1. Run engine-cleanup and select only to remove one component like WebSocket proxy or Image I/O Proxy. 
2. The cleanup script will remove all the configuration files listed in uninstall.conf.
3.

Actual results:

engine-cleanup is removing all files listed in "uninstall.conf" irrespective of the options provided.

Expected results:

engine-cleanup should consider the options provided by the user.

Additional info: